After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683692 - Ensure that all add/refresh dialogs have consistent and meaningful strings
Ensure that all add/refresh dialogs have consistent and meaningful strings
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-10 02:09 UTC by Cosimo Cecchi
Modified: 2012-09-14 22:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (26.37 KB, image/png)
2012-09-10 02:09 UTC, Cosimo Cecchi
  Details
Ensure that all dialogs have consistent and meaningful strings (9.60 KB, patch)
2012-09-14 14:01 UTC, Debarshi Ray
committed Details | Review

Description Cosimo Cecchi 2012-09-10 02:09:43 UTC
It says gnome-control-center in the title, see attached screenshot.
Comment 1 Cosimo Cecchi 2012-09-10 02:09:56 UTC
Created attachment 223873 [details]
screenshot
Comment 2 Debarshi Ray 2012-09-14 13:10:59 UTC
Thanks for noticing this. It is a remnant from the past when modal dialogs did not have the title under gnome-shell.

There are other cases too where the strings in the add/refresh need to be improved:
+ In the add account dialog we have "Add Account" in the title and "Add FOO" as a label. The label needs to go.
+ The Kerberos and Exchange dialogs use "New FOO Account" instead of "Add FOO". The strings should be consistent across all dialogs.

(changing the subject of the bug to reflect this)
Comment 3 Debarshi Ray 2012-09-14 14:01:04 UTC
Created attachment 224319 [details] [review]
Ensure that all dialogs have consistent and meaningful strings

    Now that modal dialogs have titles, we don't need an extra label. Also
    ensure that the strings used for Google, Facebook and Windows Live are
    consistent with the ones used for Exchange and Kerberos.
    
    Therefore, all modal dialogs now have "FOO account" as the title.
    
    This has the nice side-effect that we don't use "Refresh", which
    does not sound right, in the UI anymore.
Comment 4 Debarshi Ray 2012-09-14 14:01:22 UTC
This is a UI & String Freeze break.