Created attachment 220795 [details] [review]
Remove deprecated Clutter API

A work in progress patch. Currently it is crashing for me with http://fpaste.org/Zc0M/ Not sure why.

The corresponding changes in gnome-photos are working as expected.

Review of attachment 220795 [details] [review]:

I think the error is due to JS not understanding properties names with dashes. You must use underscores instead.

::: src/embed.js
@@ +78,3 @@
         this._notebook.show();
+        this._notebookActor = new GtkClutter.Actor({ contents: this._notebook,
+                                                     x-align: Clutter.ActorAlign.FILL,

You need to use underscores instead of dashes here for the property names.

@@ +99,3 @@
+                                    x-expand: true,
+                                    y-align: Clutter.ActorAlign.FILL,
+                                    y-expand: true });

Same here

::: src/errorBox.js
@@ +82,3 @@
+        let parent = this.actor.get_parent();
+        if (!parent)
+            return;

Can this actually happen? We create it and parent it in the embed's init function AFAICS.

@@ +98,3 @@
+                                           let parent = this.actor.get_parent();
+                                           if (!parent)
+                                               return;

Same here.

I committed a cleaned up version of this to master now...thanks for the patch!