After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672814 - Don't complete the hkp_source_export operation on an error
Don't complete the hkp_source_export operation on an error
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2012-03-25 19:16 UTC by Debarshi Ray
Modified: 2012-04-12 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (1.61 KB, patch)
2012-03-25 19:17 UTC, Debarshi Ray 		none Details | Review

Description Debarshi Ray 2012-03-25 19:16:09 UTC 
Occurence of an error does not mean that there are no more pending
requests. So set the error but wait for the other requests to finish.
Comment 1 Debarshi Ray 2012-03-25 19:17:35 UTC 
Created attachment 210589 [details] [review]
Proposed fix
Comment 2 Stef Walter 2012-03-27 10:35:38 UTC 
Is this a crasher fix, or a behavioral fix?

Do you think it would make sense to complete immediately, and set a flag on in the ExportClosure struct and a check early on in on_export_message_complete() which would cause further calls to be ignored.
Comment 3 Debarshi Ray 2012-03-27 20:54:50 UTC 
It is a crasher fix.

If an error occurs and the call is completed, and after that another message comes in, then an already freed object will be unreffed.

I do not know what the correct thing would be to do because I do not the cause of the errors.

I can give you a key which causes this for testing.
Comment 4 Stef Walter 2012-04-12 15:59:46 UTC 
Thanks. Merged into gnome-3-4 branch of seahorse. Will be included in 3.4.1