After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672796 - gst_element_get_name: return value should be freed
gst_element_get_name: return value should be freed
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
3.3.x
Other All
: Normal normal
: 3.4
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-25 12:08 UTC by Debarshi Ray
Modified: 2012-03-28 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
call-window: don't leak the element name (1.53 KB, patch)
2012-03-25 12:09 UTC, Debarshi Ray 		accepted-commit_after_freeze Details | Review
streamed-media-window: don't leak the element name (1.61 KB, patch)
2012-03-25 12:18 UTC, Debarshi Ray 		accepted-commit_after_freeze Details | Review

Description Debarshi Ray 2012-03-25 12:08:03 UTC 
Documentation says that the return value from gst_element_get_name should be freed.
Comment 1 Debarshi Ray 2012-03-25 12:09:29 UTC 
Created attachment 210562 [details] [review]
call-window: don't leak the element name
Comment 2 Debarshi Ray 2012-03-25 12:18:10 UTC 
Created attachment 210563 [details] [review]
streamed-media-window: don't leak the element name
Comment 3 Guillaume Desmottes 2012-03-26 09:04:14 UTC 
Review of attachment 210562 [details] [review]:

++
Comment 4 Guillaume Desmottes 2012-03-26 09:04:32 UTC 
Review of attachment 210563 [details] [review]:

++
Comment 5 Guillaume Desmottes 2012-03-26 09:05:30 UTC 
Thanks for the patches. I'll merge after the 3.4.0 release as we are now in hard code freeze.
Comment 6 Guillaume Desmottes 2012-03-27 07:06:40 UTC 
2.4.0 has been released; feel free to merge.
Comment 7 Debarshi Ray 2012-03-28 10:53:15 UTC 
Pushed to master.