After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672757 - [patch] memory leak
[patch] memory leak
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.32.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-24 15:27 UTC by Pavel Vasin
Modified: 2012-03-27 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-vtedraw-fix-leaked-PangoContext.patch (960 bytes, patch)
2012-03-24 15:27 UTC, Pavel Vasin 		accepted-commit_after_freeze Details | Review

Description Pavel Vasin 2012-03-24 15:27:06 UTC 
from valgrind log:

==32669== 972 (288 direct, 684 indirect) bytes in 6 blocks are definitely lost in loss record 6,926 of 7,144
==32669==    at 0x402B018: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==32669==    by 0x49D189A: ??? (in /usr/lib/libglib-2.0.so.0.3122.0)
==32669==    by 0x49D1C42: g_malloc (in /usr/lib/libglib-2.0.so.0.3122.0)
==32669==    by 0x49E60CD: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.3122.0)
==32669==    by 0x49E6635: g_slice_alloc0 (in /usr/lib/libglib-2.0.so.0.3122.0)
==32669==    by 0x409E18B: font_info_create_for_screen (vtedraw.c:654)
==32669==    by 0x409E211: font_info_create_for_widget (vtedraw.c:666)
==32669==    by 0x409EB25: _vte_draw_set_text_font (vtedraw.c:932)
==32669==    by 0x4083424: vte_terminal_ensure_font (vte.c:7814)
==32669==    by 0x4086272: vte_terminal_realize (vte.c:9170)
==32669==    by 0x80679E0: terminal_screen_realize (terminal-screen.c:294)
==32669==    by 0x49153CB: g_cclosure_marshal_VOID__VOID (in /usr/lib/libgobject-2.0.so.0.3122.0)
==32669==    by 0x49124DC: ??? (in /usr/lib/libgobject-2.0.so.0.3122.0)
Comment 1 Pavel Vasin 2012-03-24 15:27:48 UTC 
Created attachment 210520 [details] [review]
0001-vtedraw-fix-leaked-PangoContext.patch
Comment 2 Christian Persch 2012-03-25 12:18:29 UTC 
Comment on attachment 210520 [details] [review]
0001-vtedraw-fix-leaked-PangoContext.patch

Thanks! Looks fine, let's commit this after freeze ends on monday. Commit to vte-0-32 and vte-next branches; do you have a git account on git.gnome.org?
Comment 3 Pavel Vasin 2012-03-25 12:20:26 UTC 
>do you have a git account on git.gnome.org?

No.
Comment 4 Christian Persch 2012-03-25 12:29:15 UTC 
No problem, I'll commit them.