GNOME Bugzilla – Bug 667230
gamin server deadlock (PATCH)
Last modified: 2017-04-25 14:34:07 UTC
Created attachment 204537 [details] [review] fix possible server deadlock in ih_sub_cancel Lately I've been getting deadlocks in gam_server once every few days or so, causing e.g. KDE applications to no longer start (similar to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=542361). Looking at the code, ih_sub_cancel tries to lock a GMutex recursively, which causes undefined behavior. Attached patch should fix it. I'm currently glib 2.31.6 and glibc 2.14.1, on x86_64. Below is more information about the deadlock. The gamin server deadlocks at:
+ Trace 229384
Thread 1 (Thread 0x7f7b1b41b700 (LWP 23947))
The gamin client will hang at: connect(10, {sa_family=AF_FILE, path=@"/tmp/fam-anssi-"}, 110
Right, this patch looks to be more complete than the one from bug 669292. Fine from my side, would be good to talk to gamin maintainer before committing.
This looks to be still valid and other users downstream on Gentoo has reported the upstream works for them, could it be committed please? Thanks a lot
Ping? It appears that this longstanding bug is still in need of fixing, and there is a simple patch which reportedly fixes the problem. I think if the maintainer is AWOL it's OK to just commit this. I would do it myself if nobody objects. Of course, to get this downstream we would also need a new release.
*** Bug 669292 has been marked as a duplicate of this bug. ***
Ping
Just commit.
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
(In reply to Olav Vitters from comment #7) > This problem has been fixed in the unstable development version. The fix > will be available in the next major software release. You may need to > upgrade your Linux distribution to obtain that newer version. When the next major release will be released? I am experiencing KDE Plasma application freezes on Fedora 25 with gamin-0.1.10-23.fc25.x86_64 gamin-0.1.10-23.fc25.i686 ===================== gam_server backtrace =====================
+ Trace 237099
================= Amarok backtrace ================= See https://bugs.kde.org/show_bug.cgi?id=375301
Fedora's gamin packaging includes the commit referenced to fix this bug, yet users are still experiencing deadlocks. open a new bug?
(In reply to Rex Dieter from comment #9) > Fedora's gamin packaging includes the commit referenced to fix this bug, yet > users are still experiencing deadlocks. open a new bug? Done https://bugzilla.gnome.org/show_bug.cgi?id=777997
gam_server freezeing Dolphin https://bugs.kde.org/show_bug.cgi?id=379196