After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664756 - Produces CUE with invalid frame numbers = 75
Produces CUE with invalid frame numbers = 75
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-24 19:28 UTC by Tanguy Ortolo
Modified: 2013-08-22 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
one possible correction (1.14 KB, patch)
2011-11-24 19:28 UTC, Tanguy Ortolo
none Details | Review

Description Tanguy Ortolo 2011-11-24 19:28:12 UTC
Created attachment 202085 [details] [review]
one possible correction

When burning an audio CD, Brasero sometimes generate indexes with a frame number equal to 75, where is should be between 0 and 74 included.

This is because in plugins/audio2cue/burn-audio2cue.c:308-320, the function brasero_audio2cue_len_to_string() adds an additional frame when a time index does not end exactly on a frame number, so when the frame number was 74, it becomes 75.

You will find the initial Debian bug report with a full analysis on the Debian BTS [1].

    [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=619723

There are basically two ways to fix that: correcting the code so that it increases the time index *before* computing the frame number, second and minute, or simply stopping to increase it at all. I had a preference for this second solution, which is simpler, and which side effect would be that at most one frame, that is one 75th a second, could be lost on the track, which would in practice be impossible to notice. I have prepared a patch for that, which I attach to this bug report as well.

Librement,

-- 
Tanguy Ortolo
Comment 1 Paul Menzel 2012-10-10 06:54:13 UTC
Debian applied this patch to its Brasero package since March 2012 [1] and has not gotten a complain about it yet. Could this patch please be applied?

[1] http://packages.debian.org/changelogs/pool/main/b/brasero/brasero_3.4.1-3/changelog#version3.2.0-3.1
Comment 2 Joshua Lock 2013-08-22 16:16:08 UTC
Thanks for the patch, applied & pushed to master.