After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656283 - Failing tls connection cause assertion
Failing tls connection cause assertion
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-08-10 13:55 UTC by Sjoerd Simons
Modified: 2011-09-18 22:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (929 bytes, patch)
2011-08-10 14:01 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2011-08-10 13:55:05 UTC 
When an tls connection fails the following assertion pops up a few mainloop iteration later:

GLib-GIO-CRITICAL **: g_simple_async_result_take_error: assertion `G_IS_SIMPLE_ASYNC_RESULT (simple)' failed
Comment 1 Sjoerd Simons 2011-08-10 14:01:48 UTC 
Created attachment 193549 [details] [review]
proposed patch
Comment 2 Dan Winship 2011-08-10 14:27:21 UTC 
Comment on attachment 193549 [details] [review]
proposed patch

Yes, looks right.

It would be nice to add a test for this to glib-networking/tls/tests/tls.c. If you don't want to, then just leave this bug open after committing the fix and I'll do it at some point.
Comment 3 Matthias Clasen 2011-08-13 20:21:24 UTC 
Comment on attachment 193549 [details] [review]
proposed patch

Avoid an assertion when a TLS connection fails
Comment 4 Dan Winship 2011-09-18 22:19:34 UTC 
added a test