After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637959 - Flash plugin not disabled
Flash plugin not disabled
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-24 15:16 UTC by Carlos Garcia Campos
Modified: 2011-01-11 01:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Iterate the whole plugin list to disable flash plugin (1.08 KB, patch)
2010-12-24 15:18 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2010-12-24 15:16:31 UTC 
It seems that there might be more than one plugin instance in webkit for flash, see:

DBG: try plugin Shockwave Flash 0xb6bf8540
DBG: disabled
DBG: try plugin Windows Media Player Plug-in 10 (compatible; Totem) 0xb6bf88c0
DBG: enabled
DBG: try plugin Shockwave Flash 0xb6bf8a80
DBG: enabled

The loop that iterate the plugins to disable flash breaks when the first one is found.
Comment 1 Carlos Garcia Campos 2010-12-24 15:18:08 UTC 
Created attachment 177019 [details] [review]
Iterate the whole plugin list to disable flash plugin
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2011-01-03 19:10:34 UTC 
Carlos I only get 1 flash instance. However I agree with your patch, just to be extra safe.

Btw, it seems that we are reporting the Totem plugin as only one plugin. Xan is this a bug?
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2011-01-11 01:28:30 UTC 
Done, thanks!