After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610406 - Make sharp::string_to_lowercase() and sharp::string_substring Unicode aware
Make sharp::string_to_lowercase() and sharp::string_substring Unicode aware
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2010-02-18 21:58 UTC by Aurimas Černius
Modified: 2010-03-22 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix. (1.26 KB, patch)
2010-02-18 21:58 UTC, Aurimas Černius 		none Details | Review
Proposed fix (better solution). (762 bytes, patch)
2010-02-18 22:16 UTC, Aurimas Černius 		none Details | Review
Make functions unicode (1.24 KB, patch)
2010-03-12 19:16 UTC, Aurimas Černius 		committed Details | Review

Description Aurimas Černius 2010-02-18 21:58:50 UTC 
Created attachment 154177 [details] [review]
Proposed fix.

String is not used as unicode.
Comment 1 Aurimas Černius 2010-02-18 22:16:54 UTC 
Created attachment 154178 [details] [review]
Proposed fix (better solution).
Comment 2 Aurimas Černius 2010-03-12 19:16:11 UTC 
Created attachment 156004 [details] [review]
Make functions unicode

New patch, sharp::string_substring made unicode as well.
Comment 3 Debarshi Ray 2010-03-15 01:42:21 UTC 
Review of attachment 156004 [details] [review]:

We should convert all user facing strings to Glib::ustring. The simpler thing to do is to change the parameters to Glib::ustring and use the Glib::ustring constructor to create the return value.

Good work!
Comment 4 Debarshi Ray 2010-03-15 01:47:25 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.