After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604779 - Right click to change active row in search window
Right click to change active row in search window
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2009-12-16 21:57 UTC by Aurimas Černius
Modified: 2010-01-04 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implemented proposed feature. (2.16 KB, patch)
2009-12-16 21:57 UTC, Aurimas Černius
committed Details | Review

Description Aurimas Černius 2009-12-16 21:57:47 UTC
Created attachment 149877 [details] [review]
Implemented proposed feature.

When right click is done on a notebook, it's natural to expect, that context menu applies to that notebook.
Doing right click on a note is almost the same, except when there are multiple notes selected.

Proposed change is this:
Right click on notebook should select a notebook first, then popup a context menu for it.
Right click on note, have 3 possible cases:
* No note is selected - the clicked note should be selected and context menu openned.
* A single note is selected - selection should be removed and then the clicked note selected. Then the context menu is openned.
* Multiple notes are selected - behave as it is done now (no changes).
Comment 1 Debarshi Ray 2010-01-03 19:56:19 UTC
Review of attachment 149877 [details] [review]:

Looks fine. Thanks.

Comparing with Tomboy's sources I found that it manages to let right click change the selection for notebooks but not for notes, but there is no equivalent of the following for their notebook code:
+      if (m_notebooksTree->get_path_at_pos (ev->x, ev->y, p, col, cell_x, cell_y))
+        m_notebooksTree->get_selection()->select(p);
Comment 2 Debarshi Ray 2010-01-03 19:56:53 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.