After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597272 - Adjust the typedefs to to keep the C++ bindings happy
Adjust the typedefs to to keep the C++ bindings happy
Status: RESOLVED FIXED
Product: libchamplain
Classification: Core
Component: General
0.4.x
Other All
: Normal normal
: ---
Assigned To: libchamplain-maint
libchamplain-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-04 11:21 UTC by Debarshi Ray
Modified: 2009-10-17 08:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix (4.01 KB, patch)
2009-10-04 11:21 UTC, Debarshi Ray
committed Details | Review
Fix ChamplainZoomLevel also (1.05 KB, patch)
2009-10-17 07:27 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2009-10-04 11:21:50 UTC
Created attachment 144704 [details] [review]
Proposed fix

The headers of the gmmproc generated C++ bindings contain forward references
like:

typedef struct _Type Type;
typedef struct _TypeClass TypeClass;


These conflict with C headers containining type definitions of the form:

typedef struct {
    ...
} Type;

typedef struct {
    ...
} TypeClass;


Replacing these with the following fixes the problem:

typedef struct _Type Type;
typedef struct _TypeClass TypeClass;

struct _Type {
    ...
};

struct _TypeClass {
    ...
};
Comment 1 Pierre-Luc Beaudoin 2009-10-11 16:26:56 UTC
Good patch.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Debarshi Ray 2009-10-17 07:27:18 UTC
Created attachment 145651 [details] [review]
Fix ChamplainZoomLevel also
Comment 3 Pierre-Luc Beaudoin 2009-10-17 08:11:06 UTC
Merged :)

Tip: Next time, when attaching a patch to a closed bug, don't forget to reopen it!