GNOME Bugzilla – Bug 586541
Crashes on hitting enter twice before URLs
Last modified: 2010-10-21 16:05:52 UTC
A have a note with URLs and then I try to split the second URL in this note (put the cursor inside the URL and type ENTER) it crashes: Distribution: Unknown Gnome Release: 2.26.2 2009-05-21 (Archlinux) BugBuddy Version: 2.26.0 System: Linux 2.6.29-ARCH #1 SMP PREEMPT Wed May 20 07:06:02 UTC 2009 i686 X Vendor: The X.Org Foundation X Vendor Release: 10601901 Selinux: No Accessibility: Disabled GTK+ Theme: infinity Icon Theme: infinity GTK+ Modules: canberra-gtk-module, gnomebreakpad Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0 CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0 ---- Critical and fatal warnings logged during execution ---- ** GLib-GObject **: g_signal_emit_valist: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed ** GLib-GObject **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed ** GLib-GObject **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed ** GLib-GObject **: g_type_class_peek_parent: assertion `g_class != NULL' failed ----------- .xsession-errors --------------------- (gnote:10258): GLib-GObject-CRITICAL **: g_type_class_peek_parent: assertion `g_class != NULL' failed (gnote:10275): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer (gnote:10275): GLib-GObject-CRITICAL **: g_signal_emit_valist: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (gnote:10275): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer (gnote:10275): GLib-GObject-CRITICAL **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (gnote:10275): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer (gnote:10275): GLib-GObject-CRITICAL **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (gnote:10275): GLib-GObject-CRITICAL **: g_type_class_peek_parent: assertion `g_class != NULL' failed --------------------------------------------------
Created attachment 137122 [details] This is the note I try to edit
(In reply to comment #1) > Created an attachment (id=137122) [edit] > This is the note I try to edit > It would be nice to actually get the .note file, not an XML export. Thanks.
(In reply to comment #2) > It would be nice to actually get the .note file, not an XML export. Thanks. I meant "not an HTML export."
Created attachment 137297 [details] .note file
I've noticed that this crash is trigged even just moving the url in a new row. Step to reproduce: *enter an url *position the cursor at the beginning of the url *press two times return The first time you press return the url is correctly moved in a new row, but the second time Gnote crashes Output: (gnote:22936): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer (gnote:22936): GLib-GObject-CRITICAL **: g_signal_emit_valist: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (gnote:22936): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer (gnote:22936): GLib-GObject-CRITICAL **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (gnote:22936): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer (gnote:22936): GLib-GObject-CRITICAL **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed (gnote:22936): GLib-GObject-CRITICAL **: g_type_class_peek_parent: assertion `g_class != NULL' failed Segmentation fault
Created attachment 138783 [details] backtrace as noted in a previous comment this happens with twice moving an URL line (http://a or ftp://b tested) down a line by pressing return.
*** Bug 599786 has been marked as a duplicate of this bug. ***
Created attachment 147036 [details] gnote crash output the problem occurs when i use keyboard to navigate through the Notes [ any linked notes ]
any update about this bug ??
Created attachment 148497 [details] [review] Proposed fix The NoteEditor is Gtk::managed and constructing a Glib::RefPtr<NoteEditor> from a NoteEditor* does not increment the reference count. So the destruction of the Glib::RefPtr should be prevented from reducing its reference count.
Comment on attachment 148497 [details] [review] Proposed fix This patch looks ok to me. You can commit it if you want.
Committed and pushed.
*** Bug 632797 has been marked as a duplicate of this bug. ***