After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578990 - don't send non-idempotent requests on old SoupConnections
don't send non-idempotent requests on old SoupConnections
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2009-04-14 22:32 UTC by Dan Winship
Modified: 2011-12-22 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Winship 2009-04-14 22:32:11 UTC
we should poll connections for readability when they are idle, so that we notice right away when they get closed, rather than trying to write to them first and failing.

also, we should time out connections rather than keeping them open forever
Comment 1 Dan Winship 2009-07-29 13:28:32 UTC
setting this up so we're always polling is a little complicated, but we can cheat and just do one quick poll right before trying to use the connection.

related to this; we need to make sure that we always open a new connection when sending a non-idempotent request (eg, POST), because if we get a network error after writing the request, we won't know whether or not the server actually processed it or not. (And so we want to minimize the possibility of getting a network error, and so we don't want to use a cached-and-possibly-timed-out connection.) Apparently this is what other browsers do (qv http://www.ietf.org/mail-archive/web/hybi/current/msg00391.html).
Comment 2 Dan Winship 2010-12-10 18:58:59 UTC
updating summary to reflect remaining part of the bug
Comment 3 Dan Winship 2011-12-22 20:51:02 UTC
fixed the remaining part (and re-fixed the earlier part to work with
Windows too)