GNOME Bugzilla – Bug 87833
Sheet fonts are not anti-aliased
Last modified: 2004-12-22 21:47:04 UTC
Normal GUI fonts are anti-aliased in GNOME2, but not the sheets fonts.
I have not convert the cells to use pango yet. Only the col/row headers.
Created attachment 10230 [details] [review] gnumeric-1.1.6-pango.patch
please test this patch.
You are beautiful! I am worried about the performance implication of creating and removing layouts every time we measure a string but it is a good starting point. I'll have a more detailed analysis in a day or two.
Ok, now that 1.1.7 is out I'll have a look at this. It works nicely out of the box and you appear to have hit the major points. However, I'll need to do some performance tests.
I'm looking at the patch now.
Created attachment 10474 [details] [review] gnumeric pango patch
this patch was changed. and checked that 1.1.7 operated.
Patch applied. I adjusted the approach slightly but left most of it as is. The next question is whether we should be doing the line splitting ourselves or letting pango handle it. Eventually I'd like to more towards doing a per visible cell layout so that we can cache more. The only regression I see with the patch is that it does not handle reverse video for the autocomplete text. Lets close this one and open new bugs the resulting breakage.