After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 87833 - Sheet fonts are not anti-aliased
Sheet fonts are not anti-aliased
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.1.x
Other Linux
: Immediate normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2002-07-10 14:03 UTC by gemi
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
gnumeric-1.1.6-pango.patch (25.89 KB, patch)
2002-08-02 19:15 UTC, Shingo Akagaki
none Details | Review
gnumeric pango patch (27.10 KB, patch)
2002-08-14 06:34 UTC, Shingo Akagaki
none Details | Review

Description gemi 2002-07-10 14:03:28 UTC
Normal GUI fonts are anti-aliased in GNOME2, but
not the sheets fonts.
Comment 1 Jody Goldberg 2002-07-10 14:41:52 UTC
I have not convert the cells to use pango yet.   Only the col/row headers.
Comment 2 Shingo Akagaki 2002-08-02 19:15:43 UTC
Created attachment 10230 [details] [review]
gnumeric-1.1.6-pango.patch
Comment 3 Shingo Akagaki 2002-08-02 19:16:30 UTC
please test this patch.
Comment 4 Jody Goldberg 2002-08-04 02:20:33 UTC
You are beautiful!
I am worried about the performance implication of creating and removing layouts
every time we measure a string but it is a good starting point.  I'll have a
more detailed analysis in a day or two.
Comment 5 Jody Goldberg 2002-08-14 05:49:45 UTC
Ok, now that 1.1.7 is out I'll have a look at this.  It works nicely out of the
box and you appear to have hit the major points.  However, I'll need to do some
performance tests.
Comment 6 Jody Goldberg 2002-08-14 05:51:42 UTC
I'm looking at the patch now.
Comment 7 Shingo Akagaki 2002-08-14 06:34:24 UTC
Created attachment 10474 [details] [review]
gnumeric pango patch
Comment 8 Shingo Akagaki 2002-08-14 06:36:01 UTC
this patch was changed. and checked that 1.1.7 operated.
Comment 9 Jody Goldberg 2002-08-14 16:35:53 UTC
Patch applied.  I adjusted the approach slightly but left most of it as is.
The next question is whether we should be doing the line splitting ourselves or
letting pango handle it.  Eventually I'd like to more towards doing a per
visible cell layout so that we can cache more.

The only regression I see with the patch is that it does not handle reverse
video for the autocomplete text.

Lets close this one and open new bugs the resulting breakage.