After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794176 - [Xwayland] Unknown X11 keycode mapping 'unnamed'.
[Xwayland] Unknown X11 keycode mapping 'unnamed'.
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on:
Blocks:
 
 
Reported: 2018-03-08 15:15 UTC by Olivier Fourdan
Modified: 2018-03-13 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Use scancode instead of keycode names (3.78 KB, patch)
2018-03-08 15:15 UTC, Olivier Fourdan
none Details | Review
[PATCH v2] Use scancode instead of keycode names (2.02 KB, patch)
2018-03-09 08:33 UTC, Olivier Fourdan
none Details | Review

Description Olivier Fourdan 2018-03-08 15:15:53 UTC
Created attachment 369455 [details] [review]
[PATCH] Use scancode instead of keycode names

Description:

From downstream bug https://bugzilla.redhat.com/show_bug.cgi?id=1512564

When using gtk-vnc on Xwayland, the keycode mapping property is not available which causes unknown keycode mapping errors and the keyboard doesn't work.

  WARNING **: Unknown keycode mapping '(unnamed)'.
  CRITICAL **: send_key: assertion 'scancode != 0' failed

For each key press which is then ignored.

Fix attached.
Comment 1 Olivier Fourdan 2018-03-09 08:33:07 UTC
Created attachment 369481 [details] [review]
[PATCH v2] Use scancode instead of keycode names

 v2: Keep old code as requested, use scancodes to complement the check
     instead of replacing the previous logic entirely, as per the review
     on https://patchwork.freedesktop.org/patch/209141/.
Comment 2 Daniel P. Berrange 2018-03-13 09:30:55 UTC
Thanks, pushed to git master