After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793044 - Use upstream gettext instead of intltool
Use upstream gettext instead of intltool
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: build
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks: 763587
 
 
Reported: 2018-01-30 22:28 UTC by Robert Roth
Modified: 2021-06-10 08:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gettext (bgo#793044) (13.58 KB, patch)
2018-02-01 01:46 UTC, Robert Roth 		none Details | Review
Use gettext (bgo#793044) (14.21 KB, patch)
2018-02-02 20:59 UTC, Robert Roth 		none Details | Review
Use gettext (bgo#793044) (10.43 KB, patch)
2018-02-05 19:02 UTC, Robert Roth 		none Details | Review
Use gettext (bgo#793044) (14.23 KB, patch)
2018-02-05 19:33 UTC, Robert Roth 		none Details | Review

Description Robert Roth 2018-01-30 22:28:49 UTC 
As part of https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration, get rid of intltool, use gettext.
Comment 1 Robert Roth 2018-02-01 01:46:54 UTC 
Created attachment 367739 [details] [review]
Use gettext (bgo#793044)
Comment 2 Piotr Drąg 2018-02-01 02:45:22 UTC 
Review of attachment 367739 [details] [review]:

::: data/org.gnome.Weather.Application.desktop.in
@@ +11,3 @@
+# Translators: Search terms to find this application. Do NOT translate or localize the semicolons! The list MUST also end with a semicolon!
+Keywords=Weather;Forecast;
+X-Geoclue-Reason=Allows weather information to be displayed for your location.

X-Geoclue-Reason is a bit of a problem — gettext doesn’t recognize custom fields in .desktop files. This is how gnome-clocks deals with it: https://git.gnome.org/browse/gnome-clocks/tree/Makefile.am?h=gnome-3-24#n5
Comment 3 Robert Roth 2018-02-02 20:59:15 UTC 
Created attachment 367840 [details] [review]
Use gettext (bgo#793044)
Comment 4 Robert Roth 2018-02-05 19:02:41 UTC 
Created attachment 367926 [details] [review]
Use gettext (bgo#793044)
Comment 5 Piotr Drąg 2018-02-05 19:05:26 UTC 
Review of attachment 367926 [details] [review]:

po/Makevars is missing.
Comment 6 Robert Roth 2018-02-05 19:33:45 UTC 
Created attachment 367929 [details] [review]
Use gettext (bgo#793044)
Comment 7 André Klapper 2021-06-10 08:16:54 UTC 
Got fixed by 11d9dc98c7acd5cf891be6ca1ed680e2dd4b8ed0