After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793043 - Use upstream gettext instead of intltool
Use upstream gettext instead of intltool
Status: RESOLVED FIXED
Product: four-in-a-row
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: four-in-a-row-maint
four-in-a-row-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-30 22:11 UTC by Robert Roth
Modified: 2018-02-01 01:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gettext (bgo#793043) (9.01 KB, patch)
2018-01-31 18:33 UTC, Robert Roth 		none Details | Review
Use gettext (bgo#793043) (9.23 KB, patch)
2018-01-31 19:20 UTC, Robert Roth 		committed Details | Review

Description Robert Roth 2018-01-30 22:11:29 UTC 
As part of https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration, get rid of intltool, use gettext.
Comment 1 Robert Roth 2018-01-31 18:33:04 UTC 
Created attachment 367728 [details] [review]
Use gettext (bgo#793043)
Comment 2 Piotr Drąg 2018-01-31 18:37:20 UTC 
Review of attachment 367728 [details] [review]:

::: data/four-in-a-row.desktop.in
@@ +3,3 @@
+Name=Four-in-a-row
+Comment=Make lines of the same color to win
+Keywords=game;strategy;logic;

Keywords and Icon could use the usual comments.
Comment 3 Robert Roth 2018-01-31 19:20:13 UTC 
Created attachment 367732 [details] [review]
Use gettext (bgo#793043)
Comment 4 Michael Catanzaro 2018-01-31 21:06:04 UTC 
Review of attachment 367732 [details] [review]:

::: git.mk
@@ +81,3 @@
 	 test "x$$AUX_DIR" = "x$(srcdir)/" && AUX_DIR=$(srcdir); \
 	 for x in \
+        ABOUT-NLS \

Weird, the spacing is all messed up here... did you hack it manually? Just download the latest source from Behdad's GitHub repo (see the comment at the top of the file).

And check your tab settings in your editor ;)
Comment 5 Robert Roth 2018-02-01 01:02:00 UTC 
Review of attachment 367732 [details] [review]:

Committed the patch with the latest version of git.mk amended to the commit.
Comment 6 Robert Roth 2018-02-01 01:03:31 UTC 
Review of attachment 367732 [details] [review]:

Committed the patch with the latest version of git.mk amended to the commit.
Comment 7 Robert Roth 2018-02-01 01:03:41 UTC 
Review of attachment 367732 [details] [review]:

Committed the patch with the latest version of git.mk amended to the commit.
Comment 8 Robert Roth 2018-02-01 01:03:41 UTC 
Review of attachment 367732 [details] [review]:

Committed the patch with the latest version of git.mk amended to the commit.
Comment 9 Robert Roth 2018-02-01 01:05:34 UTC 
Bugzilla errored out 10 times while publishing the review, and now I see that it has published the review 4 times. Sorry for the noise. Can't wait for gitlab migration.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.