GNOME Bugzilla – Bug 790151
Port build system to Meson
Last modified: 2018-03-26 14:00:00 UTC
We should probably sooner or later look at porting away from GNU Automake to Meson for our build system like other GNOME modules are doing to stay in-line.
Created attachment 369978 [details] [review] Remove intltool markers from .appdata and .desktop
Created attachment 369979 [details] [review] Set launcher script template executable When building with Meson, the resulting script gets the same permissions as the template. So make sure it's set as executable.
Created attachment 369980 [details] [review] Switch to build with Meson Implement Meson build support. Re-arrange icons into directory trees corresponding to the final install directories under public datadir and package-internal datadir to avoid parsing icon file names to produce a directory hierarchy. For this reason, drop autotools support now.
Review of attachment 369978 [details] [review]: ::: data/org.gnome.Maps.desktop.in @@ +12,3 @@ DBusActivatable=true MimeType=application/vnd.geo+json;x-scheme-handler/geo;application/vnd.google-earth.kml+xml;application/gpx+xml; _X-Geoclue-Reason=Allows your location to be shown on the map. You missed one. :) It won’t be extracted by default, though, so you need a workaround similar to the one used in Clocks: https://git.gnome.org/browse/gnome-clocks/tree/data/meson.build#n13 https://git.gnome.org/browse/gnome-clocks/tree/po/meson.build
(In reply to Piotr Drąg from comment #4) > Review of attachment 369978 [details] [review] [review]: > > ::: data/org.gnome.Maps.desktop.in > @@ +12,3 @@ > DBusActivatable=true > MimeType=application/vnd.geo+json;x-scheme-handler/geo;application/vnd. > google-earth.kml+xml;application/gpx+xml; > _X-Geoclue-Reason=Allows your location to be shown on the map. > > You missed one. :) > > It won’t be extracted by default, though, so you need a workaround similar > to the one used in Clocks: > > https://git.gnome.org/browse/gnome-clocks/tree/data/meson.build#n13 > https://git.gnome.org/browse/gnome-clocks/tree/po/meson.build Thanks! I'll fix this up! :) Feel free to try out the build.
Created attachment 370023 [details] [review] Remove intltool markers from .appdata and .desktop
Created attachment 370025 [details] [review] Switch to build with Meson Implement Meson build support. Re-arrange icons into directory trees corresponding to the final install directories under public datadir and package-internal datadir to avoid parsing icon file names to produce a directory hierarchy. For this reason, drop autotools support now.
Review of attachment 370025 [details] [review]: ::: data/meson.build @@ +22,3 @@ + '--template', '@INPUT@', '-d', po_dir, '-o', '@OUTPUT@', + '--keyword=X-GNOME-FullName', '--keyword=X-Geoclue-Reason', + '--keyword=Name', '--keyword=GenericName', '--keyword=Comment', '--keyword=Keywords' Maps doesn’t have X-GNOME-FullName nor GenericName in the .desktop file.
Created attachment 370027 [details] [review] Switch to build with Meson Implement Meson build support. Re-arrange icons into directory trees corresponding to the final install directories under public datadir and package-internal datadir to avoid parsing icon file names to produce a directory hierarchy. For this reason, drop autotools support now.
(In reply to Piotr Drąg from comment #8) > Review of attachment 370025 [details] [review] [review]: > > ::: data/meson.build > @@ +22,3 @@ > + '--template', '@INPUT@', '-d', po_dir, '-o', '@OUTPUT@', > + '--keyword=X-GNOME-FullName', '--keyword=X-Geoclue-Reason', > + '--keyword=Name', '--keyword=GenericName', '--keyword=Comment', > '--keyword=Keywords' > > Maps doesn’t have X-GNOME-FullName nor GenericName in the .desktop file. Right, removed those :)
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-maps/issues/104.