After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787387 - [Patch] Migrate from intltool to gettext
[Patch] Migrate from intltool to gettext
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks: 763587
 
 
Reported: 2017-09-06 22:40 UTC by Niels De Graef
Modified: 2017-11-11 17:20 UTC
See Also:
GNOME target: 3.28
GNOME version: ---

Attachments
[Patch] Migrate from intltool to gettext (6.64 KB, patch)
2017-09-06 22:40 UTC, Niels De Graef 		none Details | Review
[Patch] Migrate from intltool to gettext (v2) (8.48 KB, patch)
2017-09-07 06:01 UTC, Niels De Graef 		accepted-commit_now Details | Review

Description Niels De Graef 2017-09-06 22:40:03 UTC 
Created attachment 359317 [details] [review]
[Patch] Migrate from intltool to gettext

Intltool is deprecated and should no longer be used. There is also [1] to encourage dropping it in GNOME tooling, in favor of GNU gettext.

Attached is a patch to perform the migration.



[1] https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration
Comment 1 Niels De Graef 2017-09-07 06:01:08 UTC 
Created attachment 359323 [details] [review]
[Patch] Migrate from intltool to gettext (v2)

Forgot to add the fixes to the .desktop files in the patch. This patch replaces the old patch.
Comment 2 Stef Walter 2017-09-11 12:14:24 UTC 
Review of attachment 359323 [details] [review]:

Nice! Did you check that this works with both intree and out of tree builds? (ie: make distcheck) ... if so, LGTM.
Comment 3 Niels De Graef 2017-09-12 10:04:23 UTC 
Yes, this should work with out-of-tree builds.

Small detail that I just noticed: the COPYRIGHT_HOLDER should be "GNOME Keyring contributors".
Comment 4 Niels De Graef 2017-11-11 17:20:27 UTC 
Patch landed on master as of commit 8818e93