After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787255 - [Patch] Migrate from intltool to gettext
[Patch] Migrate from intltool to gettext
Status: RESOLVED OBSOLETE
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks: 763587
 
 
Reported: 2017-09-04 14:00 UTC by Niels De Graef
Modified: 2018-04-19 06:58 UTC
See Also:
GNOME target: 3.28
GNOME version: ---

Attachments
[Patch] Migrate from intltool to gettext (5.77 KB, patch)
2017-09-04 14:00 UTC, Niels De Graef 		accepted-commit_now Details | Review

Description Niels De Graef 2017-09-04 14:00:22 UTC 
Created attachment 359078 [details] [review]
[Patch] Migrate from intltool to gettext

See also https://wiki.gnome.org/MigratingFromIntltoolToGettext
Comment 1 Claudio Saavedra 2017-10-27 08:45:06 UTC 
Review of attachment 359078 [details] [review]:

This looks fine. Please make sure that there are no strings removed from the pot files (the wiki mentions how to do that) and also that make distcheck passes. Then please update the gettext minimum version as commented below and push to the master branch.

::: configure.ac
@@ +128,3 @@
+dnl ***************
+AM_GNU_GETTEXT([external])
+AM_GNU_GETTEXT_VERSION([0.19.8])

Is this the minimum needed version? Libsoup is used in several non-gnome projects that might have older gettext versions. The wiki mentions 0.19.7, so if possible let's use that.
Comment 2 Tomas Popela 2018-04-16 08:30:27 UTC 
Niels, would you mind updating the patch so it works on Meson too (if anything is needed)?
Comment 3 Niels De Graef 2018-04-19 06:58:30 UTC 
The i18n module of meson already uses gettext, so this patch is no longer necessary :-)