After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783062 - Add Meson build rules
Add Meson build rules
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks: 782980
 
 
Reported: 2017-05-25 00:20 UTC by Robert Ancell
Modified: 2018-01-26 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Meson build rules (part done) (9.96 KB, patch)
2017-05-25 00:21 UTC, Robert Ancell
none Details | Review
Add Meson build rules (part done) (9.62 KB, patch)
2017-05-25 00:26 UTC, Robert Ancell
none Details | Review
Add Meson build rules (part done) (9.30 KB, patch)
2017-05-25 02:49 UTC, Robert Ancell
none Details | Review
Fully ported to meson (separate patch) (12.83 KB, patch)
2017-06-21 16:02 UTC, Niels De Graef
none Details | Review
Ported to meson (separate patch) (13.43 KB, patch)
2017-08-25 10:36 UTC, Niels De Graef
committed Details | Review

Description Robert Ancell 2017-05-25 00:20:54 UTC
Add Meson build rules
Comment 1 Robert Ancell 2017-05-25 00:21:54 UTC
Created attachment 352541 [details] [review]
Add Meson build rules (part done)

Here's a first stab at adding Meson rules. I haven't finished them and not sure if I will find the time so any one else is welcome to continue working on these.
Comment 2 Robert Ancell 2017-05-25 00:26:19 UTC
Created attachment 352542 [details] [review]
Add Meson build rules (part done)
Comment 3 Robert Ancell 2017-05-25 02:49:57 UTC
Created attachment 352545 [details] [review]
Add Meson build rules (part done)
Comment 4 Niels De Graef 2017-06-21 16:02:44 UTC
Created attachment 354165 [details] [review]
Fully ported to meson (separate patch)

Ported GNOME Calculator to Meson (patch is separate from Robert Ancell's patch).

Everything should still work as normally, with one exception: output files of autotools are no longer gitignored, but since most of GNOME apps are dropping autotools support, I figured we might as well.
Comment 5 Niels De Graef 2017-08-25 10:36:02 UTC
Created attachment 358388 [details] [review]
Ported to meson (separate patch)

Updated the Meson patch for the latest master.

For the record, to build with Meson, issue the following commands:

$ meson build
$ ninja -C build
$ mesontest -C build # in case you want to run the tests
$ build/src/gnome-calculator
Comment 6 Robert Roth 2017-08-28 22:44:36 UTC
Review of attachment 358388 [details] [review]:

Ok, this time it works. Now the only thing for me is finding out how to make releases built with Meson, as the maintainer docs on the wiki are not updated (yet).
Comment 7 Robert Roth 2018-01-26 18:53:15 UTC
Thanks, updated the build version in the meson file, and pushed to master. Marking as fixed.