After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 783027 - aacparse: fix negotiation error when reusing element
aacparse: fix negotiation error when reusing element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.12.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-24 05:58 UTC by vijay
Modified: 2017-06-02 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to reuse aac parse (1.05 KB, patch)
2017-05-24 06:05 UTC, vijay
committed Details | Review

Description vijay 2017-05-24 05:58:18 UTC
If we reuse the audio parser [aacparse] in the pipeline [Reusing: By setting pipeline to NULL and again set to playing]

Eg: Try to play file "test.aac" and play the same file by reusing the pipeline.

Getting below error:
baseparse gstbaseparse.c:2596:gst_base_parse_push_frame:<aacparse0> error: No caps set

The above failuer is due to check in function "gst_aac_parse_handle_frame"
      if (G_UNLIKELY (rate != aacparse->sample_rate
            || channels != aacparse->channels)) {
      ...
      }

Root cause:
Below private member variables were not reset properly
aacparse->channels = 0;
aacparse->sample_rate = 0;
Comment 1 vijay 2017-05-24 06:05:42 UTC
Created attachment 352469 [details] [review]
Patch to reuse aac parse

Resetting aacparse private member variables
Comment 2 Edward Hervey 2017-05-24 12:00:51 UTC
Thanks !

commit 810c0bb0845a4251bf6db341ee58f119c8129b89
Author: vijay <vijay.palaniswamy@in.bosch.com>
Date:   Wed May 24 11:33:05 2017 +0530

    aacparse : Fix, Caps were not set while reusing aacparse
    
    While reusing aacparse caps were not set.This fix enables aacparse to reuse in same pipeline.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=783027
Comment 3 Tim-Philipp Müller 2017-06-02 10:57:32 UTC
Also picked into 1.12 branch.