After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782780 - discoverer: Child/parent stream equivalence detection is too strict
discoverer: Child/parent stream equivalence detection is too strict
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.12.0
Other Linux
: Normal normal
: 1.12.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-18 10:22 UTC by Sebastian Dröge (slomo)
Modified: 2017-05-29 07:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
discoverer: Clean up more fields to decide if parent/child streams are equivalent (1.54 KB, patch)
2017-05-18 10:24 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2017-05-18 10:22:46 UTC
+++ This bug was initially created as a clone of Bug #782697 +++

Problem here is that discoverer considers child streams the same based on the caps. If the caps intersect (after removing stream-format and alignment and parsed and framed fields), they are considered the same.

However streams can also be the same otherwise, e.g. when the width/height fields differ (demuxer had wrong info, parser gets correct), or when the codec_data differs (which is the case here, h265parse creates different but equivalent codec_data).

Just looking at the caps name is not enough though, as video/mpeg can be container format or elementary stream.


We could remove more fields, basically what copy_and_clean_caps() in missing-plugins.c does.
Comment 1 Sebastian Dröge (slomo) 2017-05-18 10:24:45 UTC
Created attachment 352078 [details] [review]
discoverer: Clean up more fields to decide if parent/child streams are equivalent
Comment 2 Sebastian Dröge (slomo) 2017-05-19 09:41:31 UTC
Attachment 352078 [details] pushed as cc281e8 - discoverer: Clean up more fields to decide if parent/child streams are equivalent