After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776106 - v4l2object: Don't check size in a non-list value
v4l2object: Don't check size in a non-list value
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-14 18:22 UTC by Víctor Manuel Jáquez Leal
Modified: 2017-02-22 09:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
v4l2object: Don't check size in a non-list value (1.63 KB, patch)
2016-12-14 18:22 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-12-14 18:22:34 UTC
After commit 1ea9735a I see these error while using the webcam
integrated in my laptop:

GStreamer-CRITICAL **: gst_value_list_get_size: assertion 'GST_VALUE_HOLDS_LIST (value)' failed

The issue is gst_v4l2src_value_simplify() was doing its job of
generating a single value, rather than the original list. That why,
when getting the list size, a critical warning was raised.

This patch takes advantage of the compiler optimizations to verify
first if the list was simplified, thus use it directly, otherwise,
if it is a list, verify its size.
Comment 1 Víctor Manuel Jáquez Leal 2016-12-14 18:22:38 UTC
Created attachment 341968 [details] [review]
v4l2object: Don't check size in a non-list value
Comment 2 Víctor Manuel Jáquez Leal 2016-12-14 18:36:10 UTC
Attachment 341968 [details] pushed as 6ec3cc7 - v4l2object: Don't check size in a non-list value
Comment 3 Nicolas Dufresne (ndufresne) 2016-12-15 20:29:06 UTC
Thanks!
Comment 4 Nicolas Dufresne (ndufresne) 2017-02-22 09:15:13 UTC
In 1.10 as d4afc3bc5be9b6b6d374af0b3dcbd6f8ff8a687d
Comment 5 Nicolas Dufresne (ndufresne) 2017-02-22 09:20:20 UTC
Wrong ref, 1.10 as 4a57ff75449e1ba525df28c8b99ff9fd566430a3