GNOME Bugzilla – Bug 76984
missing gimp_help_free() in plug-ins
Last modified: 2002-04-12 14:41:44 UTC
There are some plug-ins which calls gimp_help_init() and doesn't call gimp_help_free() , and which doesn't free the memory (memory leak) See attachment patch file. (for gimp-1.2.3) plug-ins/gag/*.c also doesn't call gimp_help_free function. I don't create the patch because I can't understand those source too complex structure. Please add plug-ins/sel2path/sel2path_adv_dialog.c to po-plug- ins/POTFILES.in if you apply the patch in directly.
Created attachment 7463 [details] [review] patch which adds gimp_help_free
Created attachment 7674 [details] [review] Patch file to add gimp_help_free function for current gimp cvs HEAD (but probably you can also apply it to gimp-1.2.3)
Created attachment 7675 [details] [review] Patch file to add gimp_help_free function for current gimp cvs HEAD (but probably you can also apply it to gimp-1.2.3)
There's no need to free the resources allocated by gimp_help_init(). The OS takes care of doing this when the plug-in exits. This kind of programmers lazyness is tolerable and doesn't count as a memleak. The localisation of the sel2path dialog that is also part of your patch was omitted intentionally since the dialog is a well-hidden expert feature and any attempt to translate the very technical descriptions of the adjustable values will most probably only lead to confusion.
Will apply the patch (with a small modification) to the HEAD branch anyway since it doesn't hurt.