Created attachment 329828 [details] [review]
[PATCH] wayland: Update from scaler to viewporter protocol

Review of attachment 329828 [details] [review]:

This looks fine to me.

Review of attachment 329828 [details] [review]:

This looks fine to me.

Review of attachment 329828 [details] [review]:

::: configure.ac
@@ +2185,3 @@
+      if test "x$wayland_scanner" != "x"; then
+        HAVE_WAYLAND="yes"
+        AC_SUBST(WAYLAND_PROTOCOLS_DATADIR, `$PKG_CONFIG --variable=pkgdatadir wayland-protocols`)

I test your patch and I faced an issue while building into OpenEmbedded environment.
To get rid of this I have updated configure.ac in order to specify the PKG_CONFIG_SYSROOT_DIR while retrieving WAYLAND_PROTOCOLS_DATADIR.

AC_SUBST(WAYLAND_PROTOCOLS_DATADIR, ${PKG_CONFIG_SYSROOT_DIR}`$PKG_CONFIG --variable=pkgdatadir wayland-protocols`)

(In reply to Vincent Abriou from comment #4)
> Review of attachment 329828 [details] [review] [review]:
> 
> ::: configure.ac
> @@ +2185,3 @@
> +      if test "x$wayland_scanner" != "x"; then
> +        HAVE_WAYLAND="yes"
> +        AC_SUBST(WAYLAND_PROTOCOLS_DATADIR, `$PKG_CONFIG
> --variable=pkgdatadir wayland-protocols`)
> 
> I test your patch and I faced an issue while building into OpenEmbedded
> environment.
> To get rid of this I have updated configure.ac in order to specify the
> PKG_CONFIG_SYSROOT_DIR while retrieving WAYLAND_PROTOCOLS_DATADIR.
> 
> AC_SUBST(WAYLAND_PROTOCOLS_DATADIR, ${PKG_CONFIG_SYSROOT_DIR}`$PKG_CONFIG
> --variable=pkgdatadir wayland-protocols`)

Hmm, it seems that nowhere in any of the rest of the configure.ac's is that incantation used, so it's surprising to me that this is the only place that is broken for you.

Maybe it would be better to have your build script passed the --with-pkg-config-path argument to set pkg-config dirs, or maybe set the PKG_CONFIG variable to point to your desired copy of pkg-config.

Hi Scott,
 
My pkg-config-path is well define. While the configure phase, everything is going well. The pkgdatadir variable of wayland-protocol.pc file is well retrieve:
/user/share/wayland-protocols

Adding PKG_CONFIG_SYSROOT_DIR will specify the full path for OpenEmbedded cross compilation environment. without that, there is no way to generate viewporter-client-protocol.h because the path to viewporter.xml is incomplete.

PKG_CONFIG_SYSROOT_DIR is also used to configure Opencv plugins.

BR
Vincent

Hi Scott,

Have you any comments regarding my previous comment?

Here is the patch done in openembedded to be able to build weston 1.11 with the wayland-protocol:
http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-graphics/wayland/weston/0001-configure.ac-Fix-wayland-protocols-path.patch

I think it could be great to be able to support openembedded build for gstreamer-plugins-bad too... 

Anyway, if you don't feel confident with my proposal, it is still interesting to have you initial patch merged as soon as possible. It is the starting point to go further on wayland-protocol with gstreamer.

BR
Vinceny

Let's be honest, the weston patch this depends on looks like weird to me. Let's mere this, please file a seperate bug for build issues. We'll work with you to find a better suited solution.

Hi Nicolas,

As already wrote in my previous comment, this is fine to merge the patch as it is.
I will open a new ticket for openembedded build issue.

Br
Vincent

I do think we should make the scaling optional though.