After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767354 - qtdemux: Handle upstream GAP in push-mode/time segment
qtdemux: Handle upstream GAP in push-mode/time segment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 766647
Blocks:
 
 
Reported: 2016-06-07 15:46 UTC by Sebastian Dröge (slomo)
Modified: 2016-08-02 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtdemux: Handle upstream GAP in push-mode/time segment (323.59 KB, patch)
2016-06-07 15:46 UTC, Sebastian Dröge (slomo)
none Details | Review
qtdemux: Handle upstream GAP in push-mode/time segment (323.59 KB, patch)
2016-06-07 16:29 UTC, Sebastian Dröge (slomo)
none Details | Review
qtdemux: Handle upstream GAP in push-mode/time segment (324.19 KB, patch)
2016-06-09 16:30 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2016-06-07 15:46:05 UTC
See commit message
Comment 1 Sebastian Dröge (slomo) 2016-06-07 15:46:10 UTC
Created attachment 329293 [details] [review]
qtdemux: Handle upstream GAP in push-mode/time segment

This is to handle cases where upstream handles the fragmented streaming in TIME
segments and sends us data with gaps within fragments. This would happen when dealing
with trick-modes.

When upstream (push-based, TIME SEGMENT) wishes to send discontinuous samples,
it must obey the following rules:
* The buffer containing the [moof] must have a valid GST_BUFFER_OFFSET
* The buffers containing the first sample after a gap:
 * MUST start at the beginning of a sample,
 * MUST have the DISCONT flag set,
 * MUST have a valid GST_BUFFER_OFFSET relative to the beginning of the fragment.
Comment 2 Sebastian Dröge (slomo) 2016-06-07 16:29:47 UTC
Created attachment 329311 [details] [review]
qtdemux: Handle upstream GAP in push-mode/time segment

This is to handle cases where upstream handles the fragmented streaming in TIME
segments and sends us data with gaps within fragments. This would happen when dealing
with trick-modes.

When upstream (push-based, TIME SEGMENT) wishes to send discontinuous samples,
it must obey the following rules:
* The buffer containing the [moof] must have a valid GST_BUFFER_OFFSET
* The buffers containing the first sample after a gap:
 * MUST start at the beginning of a sample,
 * MUST have the DISCONT flag set,
 * MUST have a valid GST_BUFFER_OFFSET relative to the beginning of the fragment.
Comment 3 Sebastian Dröge (slomo) 2016-06-09 16:30:49 UTC
Created attachment 329486 [details] [review]
qtdemux: Handle upstream GAP in push-mode/time segment

This is to handle cases where upstream handles the fragmented streaming in TIME
segments and sends us data with gaps within fragments. This would happen when dealing
with trick-modes.

When upstream (push-based, TIME SEGMENT) wishes to send discontinuous samples,
it must obey the following rules:
* The buffer containing the [moof] must have a valid GST_BUFFER_OFFSET
* The buffers containing the first sample after a gap:
 * MUST start at the beginning of a sample,
 * MUST have the DISCONT flag set,
 * MUST have a valid GST_BUFFER_OFFSET relative to the beginning of the fragment.
Comment 4 Sebastian Dröge (slomo) 2016-07-01 12:21:30 UTC
Attachment 329486 [details] pushed as e3923df - qtdemux: Handle upstream GAP in push-mode/time segment