After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766203 - videoencoder/decoder: Wrong variable names used in GST_IS_*CODER_CLASS macros
videoencoder/decoder: Wrong variable names used in GST_IS_*CODER_CLASS macros
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-10 06:25 UTC by Li Jing
Modified: 2016-05-11 01:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Li Jing 2016-05-10 06:25:20 UTC
In file gstreamer/gst-plugins-base/gst-libs/gst/video/gstvideoencoder.h and gstreamer/gst-plugins-base/gst-libs/gst/video/gstvideodecoder.h.

The macro:
#define GST_IS_VIDEO_DECODER_CLASS(obj) \
  (G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_VIDEO_DECODER))

and 
#define GST_IS_VIDEO_ENCODER_CLASS(obj) \
  (G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_VIDEO_ENCODER))

Should be "klass", not "obj", though not used right now. :)
Comment 1 Sebastian Dröge (slomo) 2016-05-10 07:02:25 UTC
commit 5be3c5f6b29daf2c72c0d809db5c5fbd011eb87b
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue May 10 10:01:12 2016 +0300

    videodecoder/encoder: Correct GST_IS_*CODER_CLASS macros
    
    They are currently not used, but would result in a compiler error due to wrong
    variable name usage.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766203