After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765946 - dv: Uses different pixel-aspect-ratio than gst-libav
dv: Uses different pixel-aspect-ratio than gst-libav
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-03 16:28 UTC by Sebastian Dröge (slomo)
Modified: 2016-05-06 06:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dv: Use correct pixel-aspect-ratio values (2.34 KB, patch)
2016-05-04 06:31 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2016-05-03 16:28:04 UTC
The ones from gst-libav are from the DV code in there (libavcodec/dv_profile.c), and they give much nicer display aspect ratios when applying them to the resolutions, e.g.

libav: (720*(8/9))/480  => 4:3
dv: (720*(10/11))/480 => something odd

Someone knows what's behind this? The numbers from dv seem to be the same as on wikipedia, but might have completely different assumptions: https://en.wikipedia.org/wiki/Pixel_aspect_ratio
Comment 1 Tim-Philipp Müller 2016-05-03 16:39:19 UTC
It seems like a bug, no? Should be either 4:3 or 16:9 surely..
Comment 2 Sebastian Dröge (slomo) 2016-05-03 16:45:12 UTC
It's the same for the "16:9" ones, the ones from ffmpeg actually end up being 16:9. The ones from the DV plugin not.

The ffmpeg ones were added by me according to the ffmpeg code in bug #765946, the ones in dvdemux by Wim in bug #380944 in 2007 with a patch by Jan.
Comment 3 Sebastian Dröge (slomo) 2016-05-03 16:46:10 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> The ffmpeg ones were added by me according to the ffmpeg code in bug #765946

In bug #600895.
Comment 4 Sebastian Dröge (slomo) 2016-05-04 06:31:16 UTC
Created attachment 327264 [details] [review]
dv: Use correct pixel-aspect-ratio values

The previous ones resulted in odd display aspect ratios and were different
from the ones used by e.g. ffmpeg. The new ones now result in display aspect
ratios of 4:3 and 16:9.
Comment 5 Sebastian Dröge (slomo) 2016-05-04 06:59:09 UTC
The other thing here is that dvdemux/dvdec only seems to handle PAL/NTSC resolutions, while the ffmpeg code also does various higher resolutions.
Comment 6 Sebastian Dröge (slomo) 2016-05-05 10:37:40 UTC
Attachment 327264 [details] pushed as 83d5797 - dv: Use correct pixel-aspect-ratio values