After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763099 - ahcsrc: replace with new surfacetexture
ahcsrc: replace with new surfacetexture
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-04 13:44 UTC by Justin Kim
Modified: 2016-05-06 06:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use new surfacetexture (12.39 KB, patch)
2016-03-04 13:44 UTC, Justin Kim 		none Details | Review
use new surfacetexture (12.32 KB, patch)
2016-03-04 14:05 UTC, Justin Kim 		none Details | Review
more error handling (12.60 KB, patch)
2016-03-06 13:14 UTC, Justin Kim 		none Details | Review
remove ag surfacetexture (12.73 KB, patch)
2016-05-05 12:11 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2016-03-04 13:44:30 UTC 
Created attachment 323087 [details] [review]
use new surfacetexture

ahcsc uses old version of surfacetexture, but gstamcsurfacetexture is more reasonable.
Comment 1 Tim-Philipp Müller 2016-03-04 13:57:33 UTC 
Comment on attachment 323087 [details] [review]
use new surfacetexture

>Subject: [PATCH 2/3] androidmeida: replace with new surfacetexture for ahcsrc
>
>GstAmcSurfaceTexture is more clear and simple than GstAGSurfaceTexture.
>
>Differential Revision: https://phabricator.collabora.co.uk/D428

Please remove the reference to your private tracker from the commit message.
Comment 2 Justin Kim 2016-03-04 14:05:52 UTC 
Created attachment 323092 [details] [review]
use new surfacetexture

sorry for my mistake.
Comment 3 Sebastian Dröge (slomo) 2016-03-05 08:05:21 UTC 
Review of attachment 323092 [details] [review]:

::: sys/androidmedia/gstahcsrc.c
@@ +2356,1 @@
     gst_ah_camera_set_preview_texture (self->camera, self->texture);

If the texture creation fails, all following will segfault. Not useful error handling :)
Comment 4 Justin Kim 2016-03-06 13:14:19 UTC 
Created attachment 323192 [details] [review]
more error handling
Comment 5 Justin Kim 2016-05-05 12:11:34 UTC 
Created attachment 327343 [details] [review]
remove ag surfacetexture

Rebase and add more error handling.
Comment 6 Sebastian Dröge (slomo) 2016-05-06 06:18:29 UTC 
commit c8e34e93b27f632f0dd227c2b32053ce80b66a33
Author: Justin Kim <justin.kim@collabora.com>
Date:   Thu Mar 3 15:50:49 2016 +0900

    androidmeida: replace with new surfacetexture for ahcsrc
    
    GstAmcSurfaceTexture is more clear and simple than GstAGSurfaceTexture.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763099