GNOME Bugzilla – Bug 760209
Add to playlist dialog includes automatic playlists
Last modified: 2016-08-24 20:09:01 UTC
When I manually select tracks to add to a playlist, the add to playlist dialog allows me to select and add them to automatic playlists, like favorite songs, most played, and so on. Automatic playlists are generated automatically. It shouldn't be possible to manually add tracks to them. These playlists should therefore not be listed in the add to playlists dialog.
Created attachment 321123 [details] [review] Playlist dialog UI revamp This patch was made to make the 'add (to) playlist' dialog to resemble Allan's design in the mockup. The bug report only asked to fix the automatic playlists appearing in the dialog box, when they should not. But since there are a few other bug reports in context to the add playlist dialog I thought I would just do a revamp as depicted in the mockup and fix them all simulataneously. This would also be better than to fix them individually as that would involve a lot of code being compatible to each other for the different fixes. Please notify if there any modifications needed.
I've just quickly tested the patch. As far as I can tell, it introduces a number of issues: the dialog starts in the empty state every time, as if you don't have any playlists, even when you have them. If you create a playlist from this view, two identical playlists of that name are shown in the list. I don't see this behaviour when testing without the patch.
Review of attachment 321123 [details] [review]: please, address the issues reported by Allan Day above.
Created attachment 321264 [details] [review] Second Patch Allan this patch should hopefully fix two playlists appearing in the list. The dialog assuming no playlist (even when they are there) does not seem to appear on my setup but if you still experience that issue please notify.
Created attachment 321267 [details] [review] Second Patch The two entries appearing in the playlist dialog should not appear now. The other issue about the prompt always assuming no playlist exist (even when they do) does not appear on my system. If you still experience that issue do notify me.
Created attachment 321580 [details] [review] Third Patch This patch only improves the previous one in the sense that only playlists from MUSIC_DIR will be populated and not all user playlists that tracker can fetch. Suggested and inspired from this patch by Marinus: https://bugzilla.gnome.org/show_bug.cgi?id=761502 which strives to correct a similar issue for the main Playlist view.
(In reply to Saiful B. Khan from comment #6) > Created attachment 321580 [details] [review] [review] > Third Patch > > This patch only improves the previous one in the sense that only playlists > from > MUSIC_DIR will be populated and not all user playlists that tracker can > fetch. > > Suggested and inspired from this patch by Marinus: > https://bugzilla.gnome.org/show_bug.cgi?id=761502 > which strives to correct a similar issue for the main Playlist view. just testing here I found out that I still see the first playlist dialog although I have my playlists in there. It should be presented only when there are automatic playlists, right?
Created attachment 321615 [details] [review] Fourth Patch The mentioned issues were fixed and playlists not created by user in gnome-music (present in 'Music' directory) were excluded.
This got solved with #744834. This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.