After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760209 - Add to playlist dialog includes automatic playlists
Add to playlist dialog includes automatic playlists
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-06 12:39 UTC by Allan Day
Modified: 2016-08-24 20:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Playlist dialog UI revamp (26.34 KB, patch)
2016-02-14 16:09 UTC, Saiful B. Khan
none Details | Review
Second Patch (25.43 KB, patch)
2016-02-15 16:05 UTC, Saiful B. Khan
none Details | Review
Second Patch (25.43 KB, patch)
2016-02-15 16:09 UTC, Saiful B. Khan
none Details | Review
Third Patch (25.58 KB, patch)
2016-02-18 11:34 UTC, Saiful B. Khan
none Details | Review
Fourth Patch (26.20 KB, patch)
2016-02-18 20:16 UTC, Saiful B. Khan
none Details | Review

Description Allan Day 2016-01-06 12:39:12 UTC
When I manually select tracks to add to a playlist, the add to playlist dialog allows me to select and add them to automatic playlists, like favorite songs, most played, and so on.

Automatic playlists are generated automatically. It shouldn't be possible to manually add tracks to them. These playlists should therefore not be listed in the add to playlists dialog.
Comment 1 Saiful B. Khan 2016-02-14 16:09:24 UTC
Created attachment 321123 [details] [review]
Playlist dialog UI revamp

This patch was made to make the 'add (to) playlist' dialog to resemble Allan's design in the mockup. The bug report only asked to fix the automatic playlists appearing in the dialog box, when they should not. But since there are a few other bug reports in context to the add playlist dialog I thought I would just
do a revamp as depicted in the mockup and fix them all simulataneously. This would also be better than to fix them individually as that would involve a lot of code being compatible to each other for the different fixes.

Please notify if there any modifications needed.
Comment 2 Allan Day 2016-02-15 12:44:41 UTC
I've just quickly tested the patch. As far as I can tell, it introduces a number of issues: the dialog starts in the empty state every time, as if you don't have any playlists, even when you have them. If you create a playlist from this view, two identical playlists of that name are shown in the list.

I don't see this behaviour when testing without the patch.
Comment 3 Felipe Borges 2016-02-15 13:01:22 UTC
Review of attachment 321123 [details] [review]:

please, address the issues reported by Allan Day above.
Comment 4 Saiful B. Khan 2016-02-15 16:05:34 UTC
Created attachment 321264 [details] [review]
Second Patch

Allan this patch should hopefully fix two playlists appearing in the list. The dialog assuming no playlist (even when they are there) does not seem to appear on my setup but if you still experience that issue please notify.
Comment 5 Saiful B. Khan 2016-02-15 16:09:35 UTC
Created attachment 321267 [details] [review]
Second Patch

The two entries appearing in the playlist dialog should not appear now. The other issue about the prompt always assuming no playlist exist (even when they do) does not appear on my system. If you still experience that issue do notify me.
Comment 6 Saiful B. Khan 2016-02-18 11:34:16 UTC
Created attachment 321580 [details] [review]
Third Patch

This patch only improves the previous one in the sense that only playlists from
MUSIC_DIR will be populated and not all user playlists that tracker can fetch.

Suggested and inspired from this patch by Marinus:
https://bugzilla.gnome.org/show_bug.cgi?id=761502
which strives to correct a similar issue for the main Playlist view.
Comment 7 Felipe Borges 2016-02-18 15:18:48 UTC
(In reply to Saiful B. Khan from comment #6)
> Created attachment 321580 [details] [review] [review]
> Third Patch
> 
> This patch only improves the previous one in the sense that only playlists
> from
> MUSIC_DIR will be populated and not all user playlists that tracker can
> fetch.
> 
> Suggested and inspired from this patch by Marinus:
> https://bugzilla.gnome.org/show_bug.cgi?id=761502
> which strives to correct a similar issue for the main Playlist view.

just testing here I found out that I still see the first playlist dialog although I have my playlists in there. It should be presented only when there are automatic playlists, right?
Comment 8 Saiful B. Khan 2016-02-18 20:16:22 UTC
Created attachment 321615 [details] [review]
Fourth Patch

The mentioned issues were fixed and playlists not created by user in gnome-music (present in 'Music' directory) were excluded.
Comment 9 Marinus Schraal 2016-08-24 20:09:01 UTC
This got solved with #744834.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.