After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758733 - [PATCH] Missing mnemonic bond in financial dialog
[PATCH] Missing mnemonic bond in financial dialog
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-27 10:43 UTC by Martin Simon
Modified: 2016-01-10 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that adds a missing mnemonic bond in UI layout (924 bytes, patch)
2015-11-27 10:43 UTC, Martin Simon
committed Details | Review

Description Martin Simon 2015-11-27 10:43:46 UTC
Created attachment 316376 [details] [review]
Patch that adds a missing mnemonic bond in UI layout

This bug is clone of downstream bug https://bugzilla.redhat.com/show_bug.cgi?id=1286075.


Description of problem:
The gnome-calculator is missing one mnemonic bond in financial function dialog (Gross Profit Margin). This is unlucky, as this requires a workaround in our automation. Patch included was tested and worked without any regression.

Version-Release number of selected component (if applicable):
gnome-calculator-3.14.1-2.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. check that in Gross Profit Margin the "Margin:" label is not paired with its text entry field
Comment 1 Alberto Ruiz 2016-01-10 20:38:18 UTC
Review of attachment 316376 [details] [review]:

Looks good. Committed.
Comment 2 Alberto Ruiz 2016-01-10 20:40:28 UTC
Committed in master as 147cfc62167ae736d916f0a9d3eeb03ce82205d9 and in gnome-3-18 as 9c5ca14c59c61f9c0e47a8de7d507adbcfa42769