After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757065 - uri: incorrect behavior when merging uris ending in ..
uri: incorrect behavior when merging uris ending in ..
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-24 15:52 UTC by Florin Apostol
Modified: 2015-10-27 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
unit test reproducing the problem (1.36 KB, patch)
2015-10-24 15:55 UTC, Florin Apostol
committed Details | Review
proposed patch (873 bytes, patch)
2015-10-24 15:55 UTC, Florin Apostol
committed Details | Review

Description Florin Apostol 2015-10-24 15:52:24 UTC
According to the algorithm from https://www.ietf.org/rfc/rfc3986.txt, chapter 5.2.4.  Remove Dot Segments, the behavior for streams ending in /.. or /../ should be identical. But for current implementation, they aren't.

"one/" + "two/../" = "one/"  (correct)
"one/" + "two/.." = "one" (incorrect. It should be "one/")

This leads to "one/" + "two/.." + "three/" = "three/" instead of the expected "one/three/"
Comment 1 Florin Apostol 2015-10-24 15:55:29 UTC
Created attachment 314022 [details] [review]
unit test reproducing the problem
Comment 2 Florin Apostol 2015-10-24 15:55:51 UTC
Created attachment 314023 [details] [review]
proposed patch
Comment 3 Sebastian Dröge (slomo) 2015-10-24 17:33:45 UTC
commit 07902f6ab447046d3ac365d7a961295635d88c3a
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Sat Oct 24 16:52:44 2015 +0100

    uri: fix behaviour for merging uris ending in .. without following /
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757065

commit 63fa09fc4d92d035b062e1239da9132cd68a3964
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Sat Oct 24 16:43:59 2015 +0100

    uri: tests: added unit test for streams ending in .. without following /
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757065