After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756432 - Bluetooth status: "On" is better than "Not in Use"
Bluetooth status: "On" is better than "Not in Use"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-12 13:05 UTC by Allan Day
Modified: 2017-03-02 06:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bluetooth: Replace "Not In Use" status string with "On" (1.78 KB, patch)
2016-10-12 05:35 UTC, Bastien Nocera 		none Details | Review
bluetooth: Replace "Not In Use" status string with "On" (1.19 KB, patch)
2016-10-12 08:35 UTC, Bastien Nocera 		committed Details | Review

Description Allan Day 2015-10-12 13:05:02 UTC 
If Bluetooth is on but there aren't connected devices, the status in the menu reads "Not in Use". This is potentially confusing: it's a negative statement, even though Bluetooth is on. It also sits uneasily (and looks even more confusing) next to the submenu item "Turn Off".

Changing the string to "On" or "Bluetooth On" would be better.
Comment 1 Bastien Nocera 2016-10-12 05:35:06 UTC 
Created attachment 337490 [details] [review]
bluetooth: Replace "Not In Use" status string with "On"

If Bluetooth is on but there aren't connected devices, the status in the
menu reads "Not in Use". This is potentially confusing: it's a negative
statement, even though Bluetooth is on. It also sits uneasily (and looks
even more confusing) next to the submenu item "Turn Off".

Changing the string to "On" is better.
Comment 2 Florian Müllner 2016-10-12 08:33:25 UTC 
Review of attachment 337490 [details] [review]:

Code is obviously fine, but the patch shouldn't touch the gnome-shell-sass and gvc submodules.
Comment 3 Bastien Nocera 2016-10-12 08:35:44 UTC 
Created attachment 337503 [details] [review]
bluetooth: Replace "Not In Use" status string with "On"

If Bluetooth is on but there aren't connected devices, the status in the
menu reads "Not in Use". This is potentially confusing: it's a negative
statement, even though Bluetooth is on. It also sits uneasily (and looks
even more confusing) next to the submenu item "Turn Off".

Changing the string to "On" is better.
Comment 4 Florian Müllner 2016-10-12 08:43:52 UTC 
Review of attachment 337503 [details] [review]:

Yup
Comment 5 Bastien Nocera 2016-10-12 08:46:35 UTC 
Attachment 337503 [details] pushed as 9c6e68f - bluetooth: Replace "Not In Use" status string with "On"
Comment 6 wsxy162 2017-03-02 06:15:43 UTC 
Just "On" or "Off" is not complete, we should add device name into the string, like "Bluetooth On". See https://bugzilla.gnome.org/show_bug.cgi?id=773650