After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755121 - dahsdemux: task is signaled to stop without stop condition being set
dahsdemux: task is signaled to stop without stop condition being set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 755169
Blocks:
 
 
Reported: 2015-09-16 15:59 UTC by Florin Apostol
Modified: 2015-10-29 11:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.51 KB, patch)
2015-09-16 16:01 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-09-16 15:59:11 UTC 
The gst_adaptive_demux_stream_free function is trying to stop the stream's
download task. For this, it signals the task. But it fails to also set the 
stream->download_finished = TRUE, so the task will go back to sleep and
only exit when the download is finished.
Comment 1 Florin Apostol 2015-09-16 16:01:38 UTC 
Created attachment 311471 [details] [review]
proposed patch
Comment 2 Vincent Penquerc'h 2015-10-29 11:21:56 UTC 
Merging changed the patch substantially, it's a one liner now.

commit 60f3eb15eb0e4e4fd4612f345b9725257a0034fd
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Oct 29 11:17:48 2015 +0000

    dahsdemux: task is signaled to stop without stop condition being set
    
    The gst_adaptive_demux_stream_free function is trying to stop the stream's
    download task. For this, it signals the task. But it fails to also set the
    stream->download_finished = TRUE, so the task will go back to sleep and
    only exit when the download is finished.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755121