GNOME Bugzilla – Bug 754186
nm-version.h: #include glib.h, but NetworkManager.pc has no dependency on glib-2.0
Last modified: 2015-10-09 21:07:14 UTC
Created attachment 310105 [details] [review] Add Requires.private: glib-2.0 Since commit, http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/libnm-core/nm-version.h.in?h=nm-1-0&id=6f616d4c4b04d5478f60d0311317bc84c5459ea4 nm-version.h has #include <glib.h> So, NetworkManager.pc should pull glib-2.0 as a dependency, I'd suggest adding: Requires.private: glib-2.0 (Only noticed when some kde-related fedora builds were failing)
Hmm, we don't want NetworkManager.h (and thus NetworkManager.pc) to have a direct dependency on glib, since the stuff there is generic C defines that anything can use, even if it's not glib-based. eg, KDE should be able to use that and not pull in anything glib related. I think Thomas has been doing some fixups here, see https://bugzilla.gnome.org/show_bug.cgi?id=755938 for more details (the fixes are in the branch mentioned in the bug).
Right, including <glib.h> was actually a bug. So the solution is not to require glib, but not including it. That is fixed now both for master and nm-1-0. More details in the commit message: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=7bf10a75db84655e65fe6216d248f7775c58ca23 I'm closing this (but feel free to reopen)