After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751559 - qtmux: Implement the preset interface.
qtmux: Implement the preset interface.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.9.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-26 18:14 UTC by Mathieu Duponchelle
Modified: 2016-09-30 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtmux: Implement the preset interface. (2.27 KB, patch)
2015-06-26 18:15 UTC, Mathieu Duponchelle
none Details | Review
qtmux: Implement the preset interface. (2.27 KB, patch)
2016-09-01 02:12 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2015-06-26 18:14:59 UTC
+ And provide a "youtube" preset, which based on
https://support.google.com/youtube/answer/1722171 sets
faststart to True.
Comment 1 Mathieu Duponchelle 2015-06-26 18:15:03 UTC
Created attachment 306180 [details] [review]
qtmux: Implement the preset interface.
Comment 2 Nicolas Dufresne (ndufresne) 2015-06-26 18:26:25 UTC
Review of attachment 306180 [details] [review]:

::: gst/isomp4/GstQTMux.prs
@@ +1,2 @@
+[_presets_]
+version=0.10

Is that normal ?
Comment 3 Mathieu Duponchelle 2015-06-26 18:30:12 UTC
copy paste from vp8enc, not sure what this does actually(In reply to Nicolas Dufresne (stormer) from comment #2)

> Is that normal ?

copy paste from vp8enc, not sure what this does actually(In reply to Nicolas
Comment 4 Nicolas Dufresne (ndufresne) 2015-06-26 19:41:01 UTC
Maybe it's a left over in the 0.10 porting ? Better check what this version is supposed to be.
Comment 5 Mathieu Duponchelle 2016-09-01 02:12:18 UTC
Created attachment 334580 [details] [review]
qtmux: Implement the preset interface.

+ And provide a "youtube" preset, which based on
https://support.google.com/youtube/answer/1722171 sets
faststart to True.
Comment 6 Mathieu Duponchelle 2016-09-01 02:13:30 UTC
I gave a look at gstpreset.c, apparently this is used for checking that a preset applies at least to the version of gstreamer that is used.

A preset like GstFreeverb.prs (randomly picked) was added in 2014 and tagged with version=1.5.0.1, I assume that was the current version at the time. As I can't guarantee the preset doesn't rely on properties that were added before I wrote the patch, I'd tag it with the first version following the patch date, 1.6.0. The updated patch does just that :)
Comment 7 Sebastian Dröge (slomo) 2016-09-01 06:35:54 UTC
Comment on attachment 334580 [details] [review]
qtmux: Implement the preset interface.

Go ahead after 1.9.2 is out
Comment 8 Sebastian Dröge (slomo) 2016-09-01 10:17:24 UTC
Attachment 334580 [details] pushed as 26928b3 - qtmux: Implement the preset interface.