After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751047 - concat: Add adjust-base property
concat: Add adjust-base property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-16 14:21 UTC by Carlos Rafael Giani
Modified: 2015-06-22 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for adding adjust-base property to concat element (6.16 KB, patch)
2015-06-16 14:21 UTC, Carlos Rafael Giani
committed Details | Review

Description Carlos Rafael Giani 2015-06-16 14:21:38 UTC
Created attachment 305401 [details] [review]
Patch for adding adjust-base property to concat element

This adds a new property for disabling segment.base adjustments, which can come in handy when base is already adjusted downstream (like a streamsynchronizer). Example:


gst-launch-1.0 -v  \
  audiotestsrc samplesperbuffer=44100 num-buffers=5 name=a  \
  audiotestsrc samplesperbuffer=44100 num-buffers=7 name=b  \
  audiotestsrc samplesperbuffer=44100 num-buffers=3 name=c  \
  x. ! streamsynchronizer ! fakesink sync=true silent=false  \
  a. ! x.    b. ! x.  c. ! x.   \
  concat name=x adjust-base=false


fakesink will output 3 segment events, and their base values will be adjusted - by the streamsynchronizer, not by concat. The combination concat+streamsynchronizer can be used to mimic playbin for an audio/video stream. Audio, video, text etc. streams would each have a concat element, and all of these concat elements would be linked to the stream synchronizer. The concat elements are only used to switch between the streams sequentially ; the stream synchronizer then takes care of adjusting the segments so that both seamless playback and A/V sync are ensured.
Comment 1 Sebastian Dröge (slomo) 2015-06-22 12:11:48 UTC
commit c50e47343a98054f9fe5d7a2f27122fd20016bd9
Author: Carlos Rafael Giani <dv@pseudoterminal.org>
Date:   Tue Jun 16 16:14:18 2015 +0200

    concat: Add adjust-base property
    
    This disables the segment.base adjustments, which is useful if downstream
    takes care of base adjustments already (example: a combination of concat
    and streamsynchronizer)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751047