After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750106 - splitmuxsink: add a "format-location" signal that allows better control over filenames
splitmuxsink: add a "format-location" signal that allows better control over ...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-29 14:23 UTC by George Kiagiadakis
Modified: 2015-08-16 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.41 KB, patch)
2015-05-29 14:23 UTC, George Kiagiadakis
none Details | Review
format-location patch (2.41 KB, patch)
2015-06-24 09:33 UTC, George Kiagiadakis
committed Details | Review

Description George Kiagiadakis 2015-05-29 14:23:33 UTC
Created attachment 304266 [details] [review]
patch

Currently splitmuxsink names files after a string template that is fixated using the sequence number of the file. For some applications this may not be enough, so this patch adds a signal that applications can use to return a custom filename based on whatever criteria they want.

In my use case for example, I need the filename to contain the creation date & time.
Comment 1 Tim-Philipp Müller 2015-05-29 16:33:41 UTC
Seems like a good idea, but I dislike the 'request' part in the name a bit.

How about "format-location" ?

In Gtk+ similar properties are called "format-value" for GtkScale and "format-entry-text" for GtkComboBox.
Comment 2 George Kiagiadakis 2015-05-29 19:58:20 UTC
(In reply to Tim-Philipp Müller from comment #1)
> How about "format-location" ?

Sounds good as well. I will change it.
Comment 3 Tim-Philipp Müller 2015-06-08 10:37:19 UTC
> > How about "format-location" ?
> 
> Sounds good as well. I will change it.

Had a chance to do that yet? :)
Comment 4 George Kiagiadakis 2015-06-24 09:33:41 UTC
Created attachment 305990 [details] [review]
format-location patch

There it is, sorry for the delay.
Comment 5 Tim-Philipp Müller 2015-06-24 09:45:44 UTC
Comment on attachment 305990 [details] [review]
format-location patch

Thanks, looks good to me.

Please push after adding the bug url to the commit message and a 'Since: 1.6' marker to the signal's gtk-doc chukn.
Comment 6 Tim-Philipp Müller 2015-06-24 09:46:31 UTC
> Please push after adding the bug url to the commit message and a 'Since:
> 1.6' marker to the signal's gtk-doc chukn.

(And once git is un-frozen again, sebastian is doing releases at the moment)
Comment 7 George Kiagiadakis 2015-07-14 16:57:12 UTC
commit bbfa46363cf3e7f896ac9ec7e4e3aabea58a59b0
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Wed Apr 15 18:27:04 2015 +0200

    splitmuxsink: add a "format-location" signal that allows better control over filenames

    In certain applications, splitting into files named after a base
    location template and an incremental sequence number is not enough.

    This signal gives more fine-grained control to the application to
    decide how to name the files.

    https://bugzilla.gnome.org/show_bug.cgi?id=750106
Comment 8 George Kiagiadakis 2015-07-14 16:59:35 UTC
Note: I did not add the "Since: 1.6" marker because the whole element is new in 1.6
Comment 9 Tim-Philipp Müller 2015-07-14 17:07:26 UTC
Ah right, makes sense. Thanks.