After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748729 - small problem with base change on log
small problem with base change on log
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-01 03:11 UTC by Matthias Clasen
Modified: 2016-09-19 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix base change for log, fixes #748729 (3.82 KB, patch)
2016-09-18 23:52 UTC, Robert Roth
committed Details | Review

Description Matthias Clasen 2015-05-01 03:11:25 UTC
This was filed downstream (against 3.8.x in RHEL 7.0, but still applies):

Description of problem:
When press the [log] button, gcalctool enters the white space automatically right after "log". If I press the button to write subscript after it, gcalctool automatically removes the space, but when I use the Alt key to do it, gcalctool doesn't remove the the space automatically. This causes the "Malformed expression" error.

Version-Release number of selected component (if applicable):
gcalctool-6.4.2.1-1.fc17.i686

How reproducible:
100%

Steps to Reproduce:
1. Press button [log]
2. Hold Alt and press 2 on HW keyboard
3. Release Alt and press e.g. 512
4. Confirm
  
Actual results:
Malformed expression

Expected results:
9
Comment 1 Petr Schindler 2016-09-15 10:18:53 UTC
This bug is still relevant with gnome-calculator-3.21.90-1.fc25.x86_64 of Fedora 25.
Comment 2 Robert Roth 2016-09-18 23:52:48 UTC
Created attachment 335825 [details] [review]
Fix base change for log, fixes #748729

https://bugzilla.gnome.org/show_bug.cgi?id=748729
Ported the behaviour of the superscript/subscript toggle of removing
trailing spaces if no selection to the keyboard-only superscript/subscript
entry using modifiers.
Comment 3 Alberto Ruiz 2016-09-19 19:31:00 UTC
Review of attachment 335825 [details] [review]:

Looks great!