After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748527 - mpegtspacketizer: Change return value in find_subtable
mpegtspacketizer: Change return value in find_subtable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.4.5
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-27 14:42 UTC by Jimmy Ohn
Modified: 2015-04-28 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mpegtspacketizer: Change return value in find_subtable (809 bytes, patch)
2015-04-27 14:45 UTC, Jimmy Ohn
none Details | Review
mpegtspacketizer: Change return value in find_subtable (860 bytes, patch)
2015-04-28 02:51 UTC, Jimmy Ohn
committed Details | Review

Description Jimmy Ohn 2015-04-27 14:42:17 UTC
return type of find_subtable is static pointer.
I think that return value should be change to NULL.
Comment 1 Jimmy Ohn 2015-04-27 14:45:31 UTC
Created attachment 302452 [details] [review]
mpegtspacketizer: Change return value in find_subtable

return type of find_subtable is static pointer.
I think that return value should be change to NULL.
Comment 2 Jimmy Ohn 2015-04-28 02:51:59 UTC
Created attachment 302494 [details] [review]
mpegtspacketizer: Change return value in find_subtable

return type of find_subtable is static pointer.
I think that return value should be change to NULL.
Comment 3 Tim-Philipp Müller 2015-04-28 13:49:23 UTC
Thanks, pushed:

commit 365375a1def4d54dcf3dbc261ef2cb3486a744f6
Author: Jimmy Ohn <yongjin.ohn@lge.com>
Date:   Mon Apr 27 22:44:28 2015 +0900

    mpegtspacketizer: fix find_subtable() return value
    
    find_subtable() returns a pointer, so return NULL and
    not FALSE when nothing is found.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748527