After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747245 - navigation: Post navigation events as message on the bus
navigation: Post navigation events as message on the bus
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-02 14:19 UTC by Edward Hervey
Modified: 2015-04-29 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
video: Add a new "event" navigation message type (4.24 KB, patch)
2015-04-02 14:19 UTC, Edward Hervey
committed Details | Review
xvimagesink: Post unhandled navigation events on the bus (1.47 KB, patch)
2015-04-02 14:19 UTC, Edward Hervey
committed Details | Review
tools: Add mouse/keyboard handling from messages (2.79 KB, patch)
2015-04-02 14:19 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2015-04-02 14:19:27 UTC
For some use-cases, it would be nice to get on the bus the various
keyboard/mouse events that have taken place on the sink

The attached patches contain the proposed API, an implementation in xvimagesink
and usage in gst-play
Comment 1 Edward Hervey 2015-04-02 14:19:32 UTC
Created attachment 300820 [details] [review]
video: Add a new "event" navigation message type

This will be useful for elements that wish to post unhandled navigation
events on the bus to give the application a chance to do something with
it
Comment 2 Edward Hervey 2015-04-02 14:19:43 UTC
Created attachment 300821 [details] [review]
xvimagesink: Post unhandled navigation events on the bus
Comment 3 Edward Hervey 2015-04-02 14:19:48 UTC
Created attachment 300822 [details] [review]
tools: Add mouse/keyboard handling from messages

Allows the user to control playback with the window in focus
Comment 4 Tim-Philipp Müller 2015-04-02 16:28:03 UTC
Very cool, been meaning to add that to gst-play myself.

> [commit message]
> events on the bus to give the application
> a chance to do something with it

it -> them

 - gst_navigation_message_new_event: make ownership transfer or not explicit (= "none" here I think?)

 - gst_navigation_message_parse_event: make ownership transfer explicit (=full here?) and add a sentence to say that the caller must unref the event when no longer needed.

 - naming: been wondering if it should be 'unhandled event' rather than just 'event', because the message is only posted if the event was unhandled, no? But I guess generic is better.
Comment 5 Jan Schmidt 2015-04-25 13:31:50 UTC
Review of attachment 300820 [details] [review]:

cool
Comment 6 Jan Schmidt 2015-04-25 13:32:52 UTC
Review of attachment 300821 [details] [review]:

OK
Comment 7 Jan Schmidt 2015-04-25 13:40:39 UTC
Review of attachment 300822 [details] [review]:

cool
Comment 8 Edward Hervey 2015-04-29 13:48:12 UTC
Attachment 300820 [details] pushed as 01e2a21 - video: Add a new "event" navigation message type
Attachment 300821 [details] pushed as c90a3ac - xvimagesink: Post unhandled navigation events on the bus
Attachment 300822 [details] pushed as bba3f57 - tools: Add mouse/keyboard handling from messages