GNOME Bugzilla – Bug 747100
tests: filesink: add test for GstFileSink render_list implemention
Last modified: 2015-04-01 11:34:49 UTC
Test suite for the GstFileSink element does not check the functionality of virtual method render_list implemented by the GstFileSink. Need a testcase to verify that the implemented method for render_list by GstFileSink element works correctly.
Created attachment 300655 [details] [review] filesink: test_seeking test is updated to verify the implementation of virtual method render_list Please verify the patch.
Comment on attachment 300655 [details] [review] filesink: test_seeking test is updated to verify the implementation of virtual method render_list Thanks a lot for the patch. Better unit test coverage is always welcome. Two small nitpicks: >Subject: [PATCH] filesink: test_seeking test is updated to verify the > implementation of virtual method render_list This 'summary line' is quite long, try to make it as short and concise as possible, e.g. "tests: filesink: add check for render_list virtual method" or similar. >GstFileSink implements render_list vitual method to render list of buffers. There is no method present till now in filesink testsuit to check the functionality of this virtual method implementation by GstFileSink. >Updating the test_seeking testcase to check render_list method implementation where it push the buffer_list to the pad and verify the position to make sure it is successfully written to file. It's great that you took the time to write a detailed commit message, but this might be a bit too much detail really. You usualy don't have to justify why you add a new unit test, it's self-evident why it's a good thing. Please wrap the commit message lines (not the summary line) at ca. ~80 characters or so. About the code: it looks good, but it would be great if we could also check the actual data written out if it's not too much extra work (there seems to be a macro for that already).
Created attachment 300723 [details] [review] tests: filesink: added checks for render_list virtual method Updated patch with changes specified in review comments.
Thanks, pushed: commit 714d8e58e35cacaeab519ea0970d9a9147ee9dc1 Author: Prashant Gotarne <ps.gotarne@samsung.com> Date: Wed Apr 1 09:20:24 2015 +0530 tests: filesink: add check for render_list virtual method GstFileSink implements the render_list virtual method to render a list of buffers. Update the test_seeking test case to also check the render_list method implementation. https://bugzilla.gnome.org/show_bug.cgi?id=747100 For what it's worth, there is also the case of a buffer with multiple memories and a buffer list with buffers that each have one or more memories :)