After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746173 - new glimagesink (as glimagesinkbin) cannot copy metadata
new glimagesink (as glimagesinkbin) cannot copy metadata
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-13 18:51 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-03-14 19:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glupload: move meta-data copy into gst-gl library (1.78 KB, patch)
2015-03-14 18:51 UTC, Víctor Manuel Jáquez Leal
none Details | Review

Description Víctor Manuel Jáquez Leal 2015-03-13 18:51:12 UTC
Using today's master of gst-plugins-bad, where glimagesink is now an instance of gstimagesinkbin, and using master of gstreamer-vaapi when playing a video, this critical message is shown per frame:


gst-play-1.0:15074): GStreamer-CRITICAL **: gst_buffer_copy_into: assertion 'gst_buffer_is_writable (dest)' failed

A bisect shows that the error appeared with commit 8a0017e21d5f9a8507f0593c6b24f723aa415258

The message appear on gstgluploadelement.c:240
Comment 1 Víctor Manuel Jáquez Leal 2015-03-14 18:51:03 UTC
Created attachment 299413 [details] [review]
glupload: move meta-data copy into gst-gl library

In some upload implementations the out buffer has more than one references,
turning the buffer not writable, so it won't be possible to modify its
meta-data.

This patch moves the meta-data copy before increasing the reference of the out
buffer.
Comment 2 Matthew Waters (ystreet00) 2015-03-14 19:54:49 UTC
commit d925e7fd1946697edaa193ba446dcc276afb1b58
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Sat Mar 14 19:48:21 2015 +0100

    glupload: move meta-data copy into gst-gl library
    
    In some upload implementations the out buffer has more than one references,
    turning the buffer not writable, so it won't be possible to modify its
    meta-data.
    
    This patch moves the meta-data copy before increasing the reference of the out
    buffer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746173