GNOME Bugzilla – Bug 745606
Create a shortcut to set the speech volume
Last modified: 2015-06-05 14:33:45 UTC
Created attachment 298537 [details] [review] Added speech volume up/down shortcut, I try to change my speech syntheziser volume. I did via Preferences menu, Voice tab. Then I tried affecting a binding. This feature (increasing/decreasing volume) doesn't appear in the bindings list. Both features should have a binding, linked or not.
Comment on attachment 298537 [details] [review] Added speech volume up/down shortcut, Please do your "TODO", making the message consistent with the other messages (like the one for rate and pitch) in language.
Created attachment 298862 [details] [review] Added messages to match shortcut actions
Comment on attachment 298862 [details] [review] Added messages to match shortcut actions 1. For rate we say "faster" and "slower". For pitch we say "higher" and "lower". Perhaps it would make more sense to say "louder" and "softer"? 2. Have you actually read the translator notes. You are telling translators that the volume-related strings (both messages and command names) are pitch related.
Created attachment 299015 [details] [review] Added messages to match shortcut actions (v2)
I could just fix these myself, but.... # Translators: This string announces speech pitch change. SPEECH_UP = _("louder.") # Translators: This string announces speech pitch change. SPEECH_DOWN = _("softer.") 1. Your translator notes refer to pitch. The strings to be translated refer to volume. This will confuse translators. 2. If you look at the other strings in that file, you'll see things like: SPEECH_LOWER = _("lower.") Why did you go with SPEECH_UP for "louder" and SPEECH_DOWN for "softer"? Lastly, please provide a patch that actually applies to Orca. If you see things like: patching file src/orca/speechdispatcherfactory.py Hunk #1 succeeded at 368 (offset 5 lines). Hunk #2 FAILED at 466. Hunk #3 FAILED at 1490. That means your patch does not apply.
Created attachment 304569 [details] [review] set volume patch Here we are - Corrected the "pitch/volume" mistake - patch applies to a "git clone git://git.gnome.org/orca" thank you for your patience
Comment on attachment 304569 [details] [review] set volume patch That's better. Thank you. Committed to master: https://git.gnome.org/browse/orca/commit/?id=80c4f4ac