After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744778 - simplevideomarkdetect: move offset calculations out of inner loops
simplevideomarkdetect: move offset calculations out of inner loops
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 743908
 
 
Reported: 2015-02-19 11:21 UTC by Vineeth
Modified: 2015-02-19 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Refactored simplevideomarkdetect (3.14 KB, patch)
2015-02-19 11:22 UTC, Vineeth 		none Details | Review
Refactored simplevideomarkdetect (3.14 KB, patch)
2015-02-19 11:52 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-02-19 11:21:37 UTC 
the calculations for detecting the videomark is being repeated 
 in for loop unnecessarily. Moving this outside of for loop
 such that the code need not be executed evertime the loop is executed.
Comment 1 Vineeth 2015-02-19 11:22:48 UTC 
Created attachment 297257 [details] [review]
Refactored simplevideomarkdetect
Comment 2 Vineeth 2015-02-19 11:52:23 UTC 
Created attachment 297258 [details] [review]
Refactored simplevideomarkdetect
Comment 3 Thiago Sousa Santos 2015-02-19 13:19:52 UTC 
commit 1fa839033b88754a5fb3fedd9894d8a6fd4114e6
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Thu Feb 19 17:21:46 2015 +0530

    simplevideomarkdetect: move offset calculations out of inner loops
    
    the calculations for detecting the videomark is being repeated
    in for loop unnecessarily. Moving this outside of for loop
    such that the code need not be executed evertime the loop is executed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=744778