After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744371 - simplevideomark: move offset calculations out of inner loops
simplevideomark: move offset calculations out of inner loops
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-12 06:16 UTC by Vineeth
Modified: 2015-02-19 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Refactored simplevideomark (3.30 KB, patch)
2015-02-12 06:18 UTC, Vineeth 		none Details | Review
Refactored simplevideomark (2.80 KB, patch)
2015-02-12 06:35 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-02-12 06:16:47 UTC 
the calculations for drawing the videomark is being repeated 
 in for loop unnecessarily. Moving this outside of for loop
 such that the code need not be executed evertime the loop is executed.
Comment 1 Vineeth 2015-02-12 06:18:05 UTC 
Created attachment 296653 [details] [review]
Refactored simplevideomark
Comment 2 Vineeth 2015-02-12 06:35:37 UTC 
Created attachment 296656 [details] [review]
Refactored simplevideomark
Comment 3 Thiago Sousa Santos 2015-02-13 21:37:32 UTC 
commit 413a60959d34f7a3c75237a567ff768308c75d05
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Thu Feb 12 12:04:44 2015 +0530

    simplevideomark: refactor code
    
    the calculations for drawing the videomark is being repeated
    in for loop unnecessarily. Moving this outside of for loop
    such that the code need not be executed evertime the loop is executed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=744371