After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737579 - v4l2object: set colorspace for output devices
v4l2object: set colorspace for output devices
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal minor
: 1.4.5
Assigned To: Nicolas Dufresne (ndufresne)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-29 12:11 UTC by Aurélien Zanelli
Modified: 2014-12-16 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
v4l2object: set colorspace for output devices (3.98 KB, patch)
2014-09-29 12:12 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2014-09-29 12:11:11 UTC
When the v4l2 device is an output device, the application shall set the colorspace.

So I modify the gst_v4l2_object_set_format() to map GStreamer colorimetry info to V4L2 colorspace for output devices.
If we have no colorimetry information, I try to guess it using the pixelformat (YUV or RGB) and the video width and height.
Comment 1 Aurélien Zanelli 2014-09-29 12:12:54 UTC
Created attachment 287338 [details] [review]
v4l2object: set colorspace for output devices

Patch proposal
Comment 2 Nicolas Dufresne (ndufresne) 2014-09-29 14:39:06 UTC
Review of attachment 287338 [details] [review]:

Look good to me, thanks for the patch (and taking the time to figure-out he equivalence, I'll merge later today).
Comment 3 Nicolas Dufresne (ndufresne) 2014-09-30 01:31:13 UTC
Comment on attachment 287338 [details] [review]
v4l2object: set colorspace for output devices

commit cfb4c021871ae65a8836401768c1b816229c1191
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Mon Sep 29 11:49:45 2014 +0200

    v4l2object: set colorspace for output devices
    
    When the v4l2 device is an output device, the application shall set the
    colorspace. So map GStreamer colorimetry info to V4L2 colorspace and set
    on set_format. In case we have no colorimetry information, we try to
    guess it according to pixel format and video size.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737579
Comment 4 Nicolas Dufresne (ndufresne) 2014-09-30 01:31:55 UTC
Thanks.
Comment 5 Nicolas Dufresne (ndufresne) 2014-12-16 00:01:32 UTC
Backported to 1.4
commit 1a9bb902553fafb4a957f207449626d6a9e0aa87
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Mon Sep 29 11:49:45 2014 +0200

    v4l2object: set colorspace for output devices
    
    When the v4l2 device is an output device, the application shall set the
    colorspace. So map GStreamer colorimetry info to V4L2 colorspace and set
    on set_format. In case we have no colorimetry information, we try to
    guess it according to pixel format and video size.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737579