After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736845 - videoscale: 4Tap resize support not present for NV format
videoscale: 4Tap resize support not present for NV format
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-18 05:36 UTC by Sanjay NM
Modified: 2014-09-18 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Added 4Tap resize support in Videoscale for NV format. Tested and found it working well (8.13 KB, patch)
2014-09-18 05:36 UTC, Sanjay NM
needs-work Details | Review
videoscale: Added NV support for 4Tap Resize (6.95 KB, patch)
2014-09-18 10:20 UTC, Sanjay NM
committed Details | Review

Description Sanjay NM 2014-09-18 05:36:37 UTC
Created attachment 286438 [details] [review]
Added 4Tap resize support in Videoscale for NV format. Tested and found it working well

Added 4Tap resize support in Videoscale for NV format. Tested and is working well
Comment 1 Sebastian Dröge (slomo) 2014-09-18 09:45:46 UTC
Review of attachment 286438 [details] [review]:

::: gst/videoscale/gstvideoscale.c
@@ +407,3 @@
     case GST_VIDEO_SCALE_4TAP:
     {
+      static GstStaticCaps fourtap_filter = GST_STATIC_CAPS ("video/x-raw(ANY)," "format = (string) { RGBx, xRGB, BGRx, xBGR, RGBA, " "ARGB, BGRA, ABGR, AYUV, ARGB64, AYUV64, " "RGB, BGR, v308, YUY2, YVYU, UYVY, " "GRAY8, GRAY16_LE, GRAY16_BE, I420, YV12, " "Y444, Y42B, Y41B, RGB16, RGB15, NV21 }");    // Sanjay. Added NV21

Please indent this properly and add no // comments (git blame can be used for that information)

@@ +412,3 @@
     case GST_VIDEO_SCALE_LANCZOS:
     {
+      static GstStaticCaps lanczos_filter = GST_STATIC_CAPS ("video/x-raw(ANY)," "format = (string) { RGBx, xRGB, BGRx, xBGR, RGBA, " "ARGB, BGRA, ABGR, AYUV, ARGB64, AYUV64, " "I420, YV12, Y444, Y42B, Y41B, NV21 }");       // Sanjay. Added NV21

likewise

@@ +1384,3 @@
+        case GST_VIDEO_SCALE_4TAP:
+          vs_image_scale_4tap_Y (&dest[0], &src[0], videoscale->tmp_buf);
+          vs_image_scale_4tap_NV (&dest[1], &src[1], videoscale->tmp_buf);

You add NV12/NV21 to the lanczos caps... but did not implement the scaling for it.

::: gst/videoscale/vs_4tap.c
@@ +196,2 @@
 void
+vs_scanline_resample_4tap_NV (uint8_t * dest, uint8_t * src,

This should be static

@@ +239,3 @@
+
+void
+vs_scanline_merge_4tap_NV (uint8_t * dest, uint8_t * src1, uint8_t * src2,

And this static too
Comment 2 Sanjay NM 2014-09-18 10:20:10 UTC
Created attachment 286462 [details] [review]
videoscale: Added NV support for 4Tap Resize

Thanks for the review. Have incorporated the review comments and resubmitting the patch.
Comment 3 Sebastian Dröge (slomo) 2014-09-18 10:33:17 UTC
commit 6babe786f7400c96080faae527db51261159df28
Author: Sanjay NM <sanjay.nm@samsung.com>
Date:   Thu Sep 18 15:45:43 2014 +0530

    videoscale: Added NV support for 4Tap resize
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736845